linux-kernel - Re: [PATCH v3 04/20] power_supply: sysfs: Use power_supply

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <70066540.345820.1423508541546.JavaMail.open-xchange@oxbaltgw00.schlund.de>
Date:	Mon, 9 Feb 2015 20:02:21 +0100 (CET)
From:	Stefan Wahren <stefan.wahren@...e.com>
To:	"H. Peter Anvin" <hpa@...or.com>,
	Linus Walleij <linus.walleij@...aro.org>,
	Dmitry Eremin-Solenikov <dbaryshkov@...il.com>,
	Support Opensource <support.opensource@...semi.com>,
	Darren Hart <dvhart@...radead.org>,
	Robert Jarzmik <robert.jarzmik@...e.fr>,
	linux-pm@...r.kernel.org, Samuel Ortiz <sameo@...ux.intel.com>,
	Lee Jones <lee.jones@...aro.org>, ac100@...ts.launchpad.net,
	Cezary Jackiewicz <cezary.jackiewicz@...il.com>,
	Russell King <linux@....linux.org.uk>,
	patches@...nsource.wolfsonmicro.com, Milo Kim <milo.kim@...com>,
	David Herrmann <dh.herrmann@...glemail.com>,
	devel@...verdev.osuosl.org, Len Brown <lenb@...nel.org>,
	linux-acpi@...r.kernel.org, Ingo Molnar <mingo@...hat.com>,
	linux-input@...r.kernel.org,
	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	linux-tegra@...r.kernel.org, Daniel Mack <daniel@...que.org>,
	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	platform-driver-x86@...r.kernel.org,
	Sebastian Reichel <sre@...nel.org>,
	Julian Andres Klode <jak@...-linux.org>,
	linux-arm-kernel@...ts.infradead.org,
	Marc Dietrich <marvin24@....de>,
	David Woodhouse <dwmw2@...radead.org>,
	Jiri Kosina <jkosina@...e.cz>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-kernel@...r.kernel.org, x86@...nel.org,
	Haojian Zhuang <haojian.zhuang@...il.com>
Cc:	Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
	Pavel Machek <pavel@....cz>,
	Thomas Gleixner <tglx@...utronix.de>,
	Kyungmin Park <kyungmin.park@...sung.com>
Subject: Re: [PATCH v3 04/20] power_supply: sysfs: Use power_supply_*() API
 for accessing function attrs

Hi Krzysztof,

> Krzysztof Kozlowski <k.kozlowski@...sung.com> hat am 30. Januar 2015 um 15:47
> geschrieben:
>
>
> Replace direct calls to power supply function attributes with wrappers.
> Wrappers provide safe access in case of unregistering the power
> supply (e.g. by removing the driver). Replace:
> - get_property -> power_supply_get_property
> - set_property -> power_supply_set_property
> - property_is_writeable -> power_supply_property_is_writeable
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>
> Acked-by: Jonghwa Lee <jonghwa3.lee@...usng.com>

just a nit. It looks like a typo in the mail address which is also in patch 5 -
10.

I applied patch 1 - 14 to my repo with a upcoming power driver (mxs_power) and
didn't see any problems with your patches.

Stefan

> Acked-by: Pavel Machek <pavel@....cz>
> Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
> Reviewed-by: Sebastian Reichel <sre@...nel.org>
> ---
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/