linux-kernel - Re: linux-next: build failure after merge of the pm tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54D84747.10501@linux.intel.com>
Date:	Mon, 09 Feb 2015 13:36:07 +0800
From:	Jiang Liu <jiang.liu@...ux.intel.com>
To:	"Rafael J. Wysocki" <rjw@...ysocki.net>
CC:	Stephen Rothwell <sfr@...b.auug.org.au>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	Lorenzo Pieralisi <lorenzo.pieralisi@....com>
Subject: Re: linux-next: build failure after merge of the pm tree

Hi Rafael and Lorenzo,
	With more closer review, I suspect statement "kfree(bus_range)"
in commit d2be00c0fb5a ("of/pci: Free resources on failure in
of_pci_get_host_bridge_resources()") may cause double free of bus_range
because bus_range will also be freed by kfree(window->res);
Regards!
Gerry

On 2015/2/9 11:22, Rafael J. Wysocki wrote:
> On Monday, February 09, 2015 10:53:05 AM Jiang Liu wrote:
>>
>> On 2015/2/9 10:26, Stephen Rothwell wrote:
>>> Hi Rafael,
> 
> [cut]
> 
>>>                ^
>>>
>>> Caused by commit 14d76b68f281 ("PCI: Use common resource list
>>> management code instead of private implementation") interacting with
>>> commit d2be00c0fb5a ("of/pci: Free resources on failure in
>>> of_pci_get_host_bridge_resources()") from the pci tree.
>>>
>>> I applied the following merge fix patch (which may need more work?).
>> Hi Stephen,
>> 	Thanks for fixing it and there should no more work needed.
> 
> Can you please have a look at my linux-next branch now and see if the code
> is correct in there as well?
> 
> Rafael
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/