linux-kernel - Re: [PATCH] media:firewire:Remove unneeded function definition,avc_tuner

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Mon, 9 Feb 2015 07:43:02 +0100
From:	Stefan Richter <stefanr@...6.in-berlin.de>
To:	nick <xerofoify@...il.com>
Cc:	mchehab@....samsung.com, linux-media@...r.kernel.org,
	linux1394-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media:firewire:Remove unneeded function
 definition,avc_tuner_host2ca in firedtv-avc.c

On Feb 08 nick wrote:
> On 2015-02-08 06:55 PM, Stefan Richter wrote:
> > I still am missing research on the question whether or not the Common
> > Interface serving part of the driver needs to send Host2CA commands.  If
> > yes, we implement it and use the function.  If not, we remove the
> > function.  As long as we are not sure, I prefer to leave the #if-0'd code
> > where it is.  It documents how the command is formed, and we don't have
> > any other documentation (except perhaps the git history).
[...]
> Stefan,
> I looked in the history with git log -p 154907957f939 and all I got 
> for this function was 
>  Wed Feb 11 21:21:04 CET 2009
>     firedtv: avc: header file cleanup
>     
>         Remove unused constants and declarations.
>         Move privately used constants into .c files.

The function was added a few commits before this one, by "firesat: update
isochronous interface, add CI support".

> Clearly this states to remove unused declarations and avc_tuner_host2ca is unused.
> Can you explain to me then why it's still needed to be around if there no callers
> of it?

See above; in this instance

	#if 0
	dead code
	#endif

stands in for

	/*
	 * pseudo code
	 */
-- 
Stefan Richter
-=====-===== --=- -=--=
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/