| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 9 Feb 2015 20:22:37 -0800 From: Darren Hart <dvhart@...radead.org> To: Azael Avalos <coproscefalo@...il.com> Cc: platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v2] toshiba_acpi: Make toshiba_eco_mode_available more robust On Mon, Feb 09, 2015 at 08:55:02PM -0700, Azael Avalos wrote: > Some Toshiba laptops do not come with the ECO led installed, however, > the driver is registering support for it when it should not. > > This patch makes the toshiba_eco_mode_available function more robust > in detecting ECO led capabilities, not registering the led on laptops > that do not support it and registering the led when it really does. > > The ECO led function now returns 0x8e00 (Not Installed) by querying > with in[3] = 0, whenever theres no physical LED installed, and > returning 0x8300 (Input Data Error) when it is, however, there are > some BIOSes that have stub function calls not returning anything and > and the LED device was being registered too, hence the change of the > default return value from 1 to 0. > > Signed-off-by: Azael Avalos <coproscefalo@...il.com> Careful with whitespace errors caught by checkpatch. Fixed that and corrected a minor grammatical issue in the comment block - since I was late in reviewing ;-) Applied and queued, thanks. -- Darren Hart Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists