linux-kernel - Re: [PATCH resend 3/6] toshiba_acpi: Add support for Keyboard functions mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGdLNWEW38QPnTmKYA2zHXkOA5xTT28S6ngH1Tq5CBR9dtgfBw@mail.gmail.com>
Date:	Mon, 9 Feb 2015 21:38:51 -0700
From:	Azael Avalos <coproscefalo@...il.com>
To:	Darren Hart <dvhart@...radead.org>
Cc:	"platform-driver-x86@...r.kernel.org" 
	<platform-driver-x86@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH resend 3/6] toshiba_acpi: Add support for Keyboard
 functions mode

Hi Darren,

2015-02-09 21:08 GMT-07:00 Darren Hart <dvhart@...radead.org>:
> On Mon, Feb 09, 2015 at 08:34:51PM -0700, Azael Avalos wrote:
>> Recent Toshiba laptops that come with the new keyboard layout have
>> the Special Functions (hotkeys) enabled by default, which, in order to
>> access the F{1-12} keys, you need to press the FN-F{1-12} key to
>> access such key.
>>
>> This patch adds support to toggle the Keyboard Functions operation
>> mode by creating the sysfs entry "kbd_functions_keys", accepting only
>> two parameters, 0 to set the "Normal Operation" mode and 1 to set the
>> "Special Functions" mode, however, everytime the mode is toggled, a
>> restart is needed.
>
> Erm... that's kinda horrible :-/
>
> A couple of questions then.
>
> 1) Does the system BIOS offer a way to select one mode or the other? If so, no
> point in adding it here if a reboot is required.

Yes, I just wanted to make the driver on Linux on par with its Windows
counterpart.

>
> 2) Where Toshiba supports this (Windows?) is a reboot required?

Windows 7 and up, and yes, a reboot is required on Windows too.

>
> Rather than having to reboot, would a userspace mapping possibly be preferable?
> Could be done without a reboot.

Nope, it sets some value into a BIOS variable (register?), not even
unloading/loading
the module helps.

>
> Finally, if we keep this, we need to print something to the system log
> indicating success - and that a reboot is required to take effect.

Sure, that's no problem, its your call to keep it or drop it, just let me know
as to send an updated version.

>
> --
> Darren Hart
> Intel Open Source Technology Center

Cheers
Azael



-- 
-- El mundo apesta y vosotros apestais tambien --
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/