linux-kernel - Re: 3.19: device name associates with IRQ's for ahci controllers operating with a single IRQ changed from "ahci?" to "<BDF>"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54D9B9FA.9030900@canonical.com>
Date:	Tue, 10 Feb 2015 08:57:46 +0100
From:	Stefan Bader <stefan.bader@...onical.com>
To:	Sander Eikelenboom <linux@...elenboom.it>,
	Tejun Heo <tj@...nel.org>,
	Alexander Gordeev <agordeev@...hat.com>
CC:	linux-kernel@...r.kernel.org
Subject: Re: 3.19: device name associates with IRQ's for ahci controllers
 operating with a single IRQ changed from "ahci?" to "<BDF>"

On 09.02.2015 20:54, Sander Eikelenboom wrote:
> Hi.
> 
> In 3.19 the device name associates with IRQ's for ahci controllers operating
> with a single IRQ changed from "ahci?" to "<BDF>", was this intentional ?
> 
> It's probably commit 18dcf433f3ded61eb140a55e7048ec2fef79e723 (or another one
> in that series). 

Oh, looking at that commit that might make sense. In
ahci_host_activate_single_irq it now uses dev_driver_name instead of dev_name as
it did before (from ata_host_activate).  The description sounds like before the
driver is registered this will return the bus. And registering an interrupt
would likely be before the driver is fully registered... But you probably saw
that, too. Whether that really was intentional is still the question. :)

-Stefan

>
> --
> Sander
> 
> 
> /proc/interrupts of an ahci controller with a single irq:
>  52:      13529          0          0          0  xen-pirq-msi       0000:00:1f.2
> 
> /proc/interrupts of an ahci controller with multiple irq's:
>  114:     412535          0          0          0          0          0  xen-pirq-msi       ahci0
>  115:          0          0          0          0          0          0  xen-pirq-msi       ahci1
>  116:      16717          0          0          0          0          0  xen-pirq-msi       ahci2
>  117:          0          0          0          0          0          0  xen-pirq-msi       ahci3
>  118:          0          0          0          0          0          0  xen-pirq-msi       ahci4
>  119:          0          0          0          0          0          0  xen-pirq-msi       ahci5
> 
> 



Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)