linux-kernel - Re: [PATCH 1/1] staging: unisys: Remove allocation from declaration line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150210134327.GA15535@sudip-PC>
Date:	Tue, 10 Feb 2015 19:13:27 +0530
From:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:	Quentin Lambert <lambert.quentin@...il.com>
Cc:	Benjamin Romer <benjamin.romer@...sys.com>,
	David Kershner <david.kershner@...sys.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	kernel-janitors@...r.kernel.org, sparmaintainer@...sys.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] staging: unisys: Remove allocation from declaration
 line

On Tue, Feb 10, 2015 at 02:02:14PM +0100, Quentin Lambert wrote:
> This patch removes allocation from declaration line because
> people are known to gloss over declarations.
> 
> Signed-off-by: Quentin Lambert <lambert.quentin@...il.com>
> ---
>  drivers/staging/unisys/visorchipset/visorchipset_main.c | 6 +++---
>  drivers/staging/unisys/visorutil/charqueue.c            | 3 ++-
>  drivers/staging/unisys/visorutil/memregion_direct.c     | 5 +++--
>  3 files changed, 8 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/staging/unisys/visorchipset/visorchipset_main.c b/drivers/staging/unisys/visorchipset/visorchipset_main.c
> index 82e259d..a6c6bb7 100644
> --- a/drivers/staging/unisys/visorchipset/visorchipset_main.c
> +++ b/drivers/staging/unisys/visorchipset/visorchipset_main.c
> @@ -1604,9 +1604,9 @@ parahotplug_next_expiration(void)
>  static struct parahotplug_request *
>  parahotplug_request_create(struct controlvm_message *msg)
>  {
> -	struct parahotplug_request *req =
> -	    kmalloc(sizeof(struct parahotplug_request),
> -		    GFP_KERNEL|__GFP_NORETRY);
> +	struct parahotplug_request *req;
> +
> +	req = kmalloc(sizeof(struct parahotplug_request), GFP_KERNEL|__GFP_NORETRY);
if you make it as:
	req = kmalloc(sizeof(*req), GFP_KERNEL|__GFP_NORETRY);
then this will not give you checkpatch warning of line over 80 char.

regards
sudip

>  	if (req == NULL)
>  		return NULL;
<snip>	
>  		return NULL;
> -- 
> 1.9.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/