linux-kernel - Re: [trivial PATCH] mod_devicetable.h: Make the definition of struct of_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_JsqLEZkgFMmGsiiJJOY+CR4+wNqdZQPC93TtyVtnwP+k4cA@mail.gmail.com>
Date:	Mon, 9 Feb 2015 19:35:54 -0600
From:	Rob Herring <robherring2@...il.com>
To:	Joe Perches <joe@...ches.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Grant Likely <grant.likely@...aro.org>,
	Rob Herring <robh+dt@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Jeff Mahoney <jeffm@...e.com>
Subject: Re: [trivial PATCH] mod_devicetable.h: Make the definition of struct
 of_device_id easier to find

On Mon, Feb 9, 2015 at 3:15 PM, Joe Perches <joe@...ches.com> wrote:
> Move the open brace so the definition matches the more
> common kernel style.  This makes grep a bit easier.

I've got the same fix in -next for 3.20 already:

commit 851c63e3b381fdbf5aca1a797f37d8606b5588d2
Author: Daniel Thompson <daniel.thompson@...aro.org>
Date:   Mon Jan 5 15:43:39 2015 +0000

    of: Fix brace position for struct of_device_id definition

    Currently it is not easy to grep for the definition of struct of_device_id.
    This is trivially fixed by moving the brace to the right place.

    Signed-off-by: Daniel Thompson <daniel.thompson@...aro.org>
    Cc: Grant Likely <grant.likely@...aro.org>
    Cc: Rob Herring <robh+dt@...nel.org>
    Signed-off-by: Rob Herring <robh@...nel.org>

>
> Signed-off-by: Joe Perches <joe@...ches.com>
> ---
>  include/linux/mod_devicetable.h | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/include/linux/mod_devicetable.h b/include/linux/mod_devicetable.h
> index 470a240..2e75ab0 100644
> --- a/include/linux/mod_devicetable.h
> +++ b/include/linux/mod_devicetable.h
> @@ -220,8 +220,7 @@ struct serio_device_id {
>  /*
>   * Struct used for matching a device
>   */
> -struct of_device_id
> -{
> +struct of_device_id {
>         char    name[32];
>         char    type[32];
>         char    compatible[128];
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/