linux-kernel - Re: [GIT] Networking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFwxuMcNPU-C5p2hSWuNhJW+DOi3Py0NQ--Rw9_bv3md2w@mail.gmail.com>
Date:	Tue, 10 Feb 2015 08:58:55 -0800
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	David Miller <davem@...emloft.net>
Cc:	Al Viro <viro@...iv.linux.org.uk>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Network Development <netdev@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [GIT] Networking

On Tue, Feb 10, 2015 at 8:33 AM, Linus Torvalds
<torvalds@...ux-foundation.org> wrote:
>
> Will try your suggestion,

Nope, that wasn't it. It still hangs in the same place (I forgot to
get rid of the red hat graphical boot screen so I didn't see the oops,
but ..)

Looking more closely at the generated code, and the fact that the oops
was an access at offset 0x18 from a NULL pointer, it would *look* like
it's this instruction:

        call    *24(%rax)       # MEM[(struct ablkcipher_tfm *)_48 + 8B].decrypt

in the asm. Very odd. That part doesn't seem to have changed at all
(it's the crypto_ablkcipher_decrypt() part inside the
af_alg_wait_for_completion call).

Ignoring whitespace changes and doing a

    git show -w 1d10eb2f156f crypto/algif_skcipher.c

does make it clear that apart from the "iter" changes, the only real
difference seems to be to the usage of "used". But I can't judge the
iter changes. And maybe something else changed elsewhere.

Any other ideas? Al?

                       Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/