linux-kernel - Re: [RFC] pstore-ram: remove superfluous memory size check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54DA3B0A.5000209@android.com>
Date:	Tue, 10 Feb 2015 09:08:26 -0800
From:	Mark Salyzyn <salyzyn@...roid.com>
To:	Kiran Raparthy <kumarsharma.r@...il.com>,
	linux-kernel@...r.kernel.org
CC:	Mark Salyzyn <salyzyn@...gle.com>,
	Anton Vorontsov <anton@...msg.org>,
	Colin Cross <ccross@...roid.com>,
	Kees Cook <keescook@...omium.org>,
	Tony Luck <tony.luck@...el.com>
Subject: Re: [RFC] pstore-ram: remove superfluous memory size check

Please refer to '[PATCH v2 2/5] pstore: remove superfluous memory size 
check'

Sincerely -- Mark Salyzyn

On 02/10/2015 02:26 AM, Kiran Raparthy wrote:
> From: Mark Salyzyn <salyzyn@...gle.com>
>
> pstore-ram: remove superfluous memory size check
>
> All previous checks will fail with error if memory size
> is not sufficient to register a zone, so this legacy
> check has become redundant.
>
> Cc: Anton Vorontsov <anton@...msg.org>
> Cc: Colin Cross <ccross@...roid.com>
> Cc: Kees Cook <keescook@...omium.org>
> Cc: Tony Luck <tony.luck@...el.com>
> Cc: linux-kernel@...r.kernel.org
> Signed-off-by: Mark Salyzyn <salyzyn@...roid.com>
> [Kiran: Added Context]
> Signed-off-by: Kiran Raparthy <kumarsharma.r@...il.com>
>
> ---
> This is one of the number of patches from the Android AOSP common.git tree,
> which is used on Android devices. I wanted to submit it for review
> to see if it should go upstream.
> [PATCH v2 2/5] pstore: remove superfluous memory size check
>   fs/pstore/ram.c | 9 ---------
>   1 file changed, 9 deletions(-)
>
> diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c
> index 8613e5b..34ed8f8 100644
> --- a/fs/pstore/ram.c
> +++ b/fs/pstore/ram.c
> @@ -474,14 +474,6 @@ static int ramoops_probe(struct platform_device *pdev)
>   	if (err)
>   		goto fail_init_fprz;
>   
> -	if (!cxt->przs && !cxt->cprz && !cxt->fprz) {
> -		pr_err("memory size too small, minimum is %zu\n",
> -			cxt->console_size + cxt->record_size +
> -			cxt->ftrace_size);
> -		err = -EINVAL;
> -		goto fail_cnt;
> -	}
> -
>   	cxt->pstore.data = cxt;
>   	/*
>   	 * Console can handle any buffer size, so prefer LOG_LINE_MAX. If we
> @@ -525,7 +517,6 @@ fail_buf:
>   	kfree(cxt->pstore.buf);
>   fail_clear:
>   	cxt->pstore.bufsize = 0;
> -fail_cnt:
>   	kfree(cxt->fprz);
>   fail_init_fprz:
>   	kfree(cxt->cprz);

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/