linux-kernel - Re: [PATCH 2/2] staging: panel: initialize lcd if lcd enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150210175312.GB9067@1wt.eu>
Date:	Tue, 10 Feb 2015 18:53:12 +0100
From:	Willy Tarreau <w@....eu>
To:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc:	Willy Tarreau <willy@...a-x.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] staging: panel: initialize lcd if lcd enabled

On Tue, Feb 10, 2015 at 05:26:03PM +0530, Sudip Mukherjee wrote:
> initialiaze lcd parameters only if lcd is enabled.
> 
> Signed-off-by: Sudip Mukherjee <sudip@...torindia.org>

One minor comment below (cosmetic), but after this it's OK.
Acked-by: Willy Tarreau <w@....eu>

> +	if (lcd.enabled) {
> +		/*
> +		 * Init lcd struct with load-time values to preserve exact
> +		 * current functionality (at least for now).
> +		 */
> +		lcd.height = lcd_height;
> +		lcd.width = lcd_width;
> +		lcd.bwidth = lcd_bwidth;
> +		lcd.hwidth = lcd_hwidth;
> +		lcd.charset = lcd_charset;
> +		lcd.proto = lcd_proto;
> +		lcd.pins.e = lcd_e_pin;
> +		lcd.pins.rs = lcd_rs_pin;
> +		lcd.pins.rw = lcd_rw_pin;
> +		lcd.pins.cl = lcd_cl_pin;
> +		lcd.pins.da = lcd_da_pin;
> +		lcd.pins.bl = lcd_bl_pin;
> +
> +	/* Leave it for now, just in case */
^^^^^^^^^^^^^^^^^^^
Please fix indenting the comment here.

> +		lcd.esc_seq.len = -1;
> +	}
> +

Willy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/