linux-kernel - Re: [PATCH] ARM: shmobile: r8a73a4: Move pfc node to work around probe ordering bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3282348.ooqjOMyZ9x@avalon>
Date:	Tue, 10 Feb 2015 20:53:44 +0200
From:	Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	Tony Lindgren <tony@...mide.com>,
	Geert Uytterhoeven <geert+renesas@...der.be>,
	Simon Horman <horms@...ge.net.au>,
	Magnus Damm <magnus.damm@...il.com>,
	Rob Herring <robh+dt@...nel.org>,
	Grant Likely <grant.likely@...aro.org>,
	Thierry Reding <thierry.reding@...il.com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	Linux-sh list <linux-sh@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ARM: shmobile: r8a73a4: Move pfc node to work around probe ordering bug

Hi Geert,

On Tuesday 10 February 2015 11:19:39 Geert Uytterhoeven wrote:
> On Mon, Feb 9, 2015 at 7:29 PM, Tony Lindgren <tony@...mide.com> wrote:
> > * Geert Uytterhoeven <geert@...ux-m68k.org> [150209 09:17]:
> >> On Mon, Feb 9, 2015 at 5:24 PM, Tony Lindgren <tony@...mide.com> wrote:
> >>> * Geert Uytterhoeven <geert+renesas@...der.be> [150206 12:26]:
> >>>> Notes:
> >>>>   - It seems several people tried to solve this in the core OF probing
> >>>>     code before, but the final solution never went in?
> >>>>   
> >>>>   - This can be reproduced on other SoCs (e.g. sh73a0 and r8a7740) by
> >>>>     moving their pfc nodes before their interrupt controller nodes.
> >>>>   
> >>>>   - This patch is against my working tree, so it doesn't apply to
> >>>>     Simon's repository, but you get the idea....
> >>> 
> >>> No issues with the patch, but here are few comments on the core
> >>> reasons (without looking at the code in this case) that might help
> >>> fix similar issues.
> >>> 
> >>> In all the cases I've seen these errors are caused by non-standard
> >>> custom initcall levels for drivers like i2c bus. The real solution
> >>> is to initialize drivers later with standard module_init, and stop
> >>> the race to the bottom with custom initcall levels.
> >>> 
> >>> If there is legacy board specific platofrm init code that needs
> >>> i2c gpios early, that code can probably be moved to initialize
> >>> later on.
> >> 
> >> In this case no i2c is involved. The drivers for both pinctrl
> >> (renesas,pfc-r8a73a4) and irqchip (renesas,irqc) are registered
> >> 
> >> at the same level:
> >>   - postcore_initcall(sh_pfc_init);
> >>   - postcore_initcall(irqc_init);
> >> 
> >> Hence the system uses the "natural" order from within the DTS,
> >> and decided to instantiate the pfc before the irqchip.
> > 
> > OK
> 
> I tried converting the renesas,irqc driver to IRQCHIP_DECLARE().
> This solves the probe ordering problem, but it no longer allows the use of
> a platform device.

One (quite hackish) possible way around this is to register the platform 
driver (using a static variable to ensure the driver isn't registered multiple 
times) in the IRQCHIP_DECLARE'd init function, and then call 
of_platform_device_create() to create the platform device. This should get the 
device probed immediately.

> As I was already adding clock and runtime PM support
> (which use platform devices), IRQCHIP_DECLARE doesn't look like the
> right road to follow...

-- 
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/