linux-kernel - Re: [RFC PATCH 8/9] livepatch: allow patch modules to be removed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 10 Feb 2015 20:02:34 +0100
From:	Jiri Slaby <jslaby@...e.cz>
To:	Josh Poimboeuf <jpoimboe@...hat.com>,
	Seth Jennings <sjenning@...hat.com>,
	Jiri Kosina <jkosina@...e.cz>, Vojtech Pavlik <vojtech@...e.cz>
CC:	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>,
	live-patching@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH 8/9] livepatch: allow patch modules to be removed

On 02/09/2015, 06:31 PM, Josh Poimboeuf wrote:
> --- a/kernel/livepatch/core.c
> +++ b/kernel/livepatch/core.c
...
> @@ -497,10 +500,6 @@ static struct attribute *klp_patch_attrs[] = {
>  
>  static void klp_kobj_release_patch(struct kobject *kobj)
>  {
> -	/*
> -	 * Once we have a consistency model we'll need to module_put() the
> -	 * patch module here.  See klp_register_patch() for more details.
> -	 */

I deliberately let you write the note in there :). What happens when I
leave some attribute in /sys open and you remove the module in the meantime?

> --- a/kernel/livepatch/transition.c
> +++ b/kernel/livepatch/transition.c
> @@ -54,6 +54,9 @@ void klp_complete_transition(void)
>  		for (func = obj->funcs; func->old_name; func++)
>  			func->transition = 0;
>  
> +	if (klp_universe_goal == KLP_UNIVERSE_OLD)
> +		module_put(klp_transition_patch->mod);
> +
>  	klp_transition_patch = NULL;
>  }

regards,
-- 
js
suse labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/