linux-kernel - Re: [PATCH] module: Annotate nested sleep in resolve

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8761b9coq5.fsf@rustcorp.com.au>
Date:	Wed, 11 Feb 2015 10:18:34 +1030
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Dave Jones <davej@...emonkey.org.uk>,
	Peter Zijlstra <peterz@...radead.org>
Cc:	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] module: Annotate nested sleep in resolve_symbol()

Dave Jones <davej@...emonkey.org.uk> writes:
> On Tue, Feb 10, 2015 at 06:12:55PM +0100, Peter Zijlstra wrote:
>  > On which, we should probably do this.
>  > 
>  > ---
>  > Subject: module: Replace over-engineered nested sleep 
>  > 
>  > Since the introduction of the nested sleep warning; we've established
>  > that the occasional sleep inside a wait_event() is fine.
>  > 
>  > wait_event() loops are invariant wrt. spurious wakeups, and the
>  > occasional sleep has a similar effect on them. As long as its occasional
>  > its harmless.
>  > 
>  > Therefore replace the 'correct' but verbose wait_woken() thing with
>  > a simple annotation to shut up the warning.
>  > 
>  > Cc: Rusty Russell <rusty@...tcorp.com.au>
>  > Signed-off-by: Peter Zijlstra (Intel) <peterz@...radead.org>
>
> Seems to suppress the warning, and modules still work.
>
> Tested-by: Dave Jones <davej@...emonkey.org.uk>

OK, applied.

Thanks!
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/