linux-kernel - Re: [PATCH 2/6] staging: rtl8188eu: hal: removed code indent error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1423647637.15343.16.camel@perches.com>
Date:	Wed, 11 Feb 2015 01:40:37 -0800
From:	Joe Perches <joe@...ches.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Bas Peters <baspeters93@...il.com>,
	Sudip Mukherjee <sudipm.mukherjee@...il.com>,
	devel@...verdev.osuosl.org, gmate.amit@...il.com,
	gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
	Pushpendra Singh <pushpendra.singh@...rtplayin.com>,
	manuel.schoelling@....de
Subject: Re: [PATCH 2/6] staging: rtl8188eu: hal: removed code indent error

On Wed, 2015-02-11 at 11:33 +0300, Dan Carpenter wrote:
> On Tue, Feb 10, 2015 at 03:27:11PM +0100, Bas Peters wrote:
> > >> @@ -101,8 +101,7 @@ void rtl88eu_phy_rf6052_set_cck_txpower(struct adapter *adapt, u8 *powerlevel)
> > >>                       ptr++;
> > >>               }
> > >>       }
> > >> -     rtl88eu_dm_txpower_track_adjust(&hal_data->odmpriv, 1, &direction,
> > >> -                                     &pwrtrac_value);
> > >> +     rtl88eu_dm_txpower_track_adjust(&hal_data->odmpriv, 1, &direction, &pwrtrac_value);
> > > you are introducing one warning to fix one error. line over 80 character.
> > 
> > Isn't that warning more of a guideline, rather than an actual warning?

Yes, it is more informational than defect.

> You can't fight checkpatch.pl.

Sure you can,  Ignore it whenever appropriate.

It's a pity there are _so_ many people that think
checkpatch messages are gospel.

> We reject the worst or the worst "break
> lines up into smaller chunks" patches where they obviously hurt
> readability, but we almost always silence the warning in the end.  The
> original code in this case was fine.

Any line with 30+ char identifiers generally doesn't
fit well in 80 char lines.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/