linux-kernel - Re: [PATCH 4/6] ALSA: line6: Return EIO if read/write not successful

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5h7fvo7phq.wl-tiwai@suse.de>
Date:	Wed, 11 Feb 2015 10:43:13 +0100
From:	Takashi Iwai <tiwai@...e.de>
To:	Chris Rorvick <chris@...vick.com>
Cc:	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
	Stefan Hajnoczi <stefanha@...il.com>
Subject: Re: [PATCH 4/6] ALSA: line6: Return EIO if read/write not successful

At Tue, 10 Feb 2015 23:03:15 -0600,
Chris Rorvick wrote:
> 
> Signed-off-by: Chris Rorvick <chris@...vick.com>

Applied, thanks.


Takashi

> ---
>  sound/usb/line6/driver.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/usb/line6/driver.c b/sound/usb/line6/driver.c
> index 2a33f3e..f8e2eb0 100644
> --- a/sound/usb/line6/driver.c
> +++ b/sound/usb/line6/driver.c
> @@ -349,7 +349,7 @@ int line6_read_data(struct usb_line6 *line6, u16 address, void *data,
>  		dev_err(line6->ifcdev,
>  			"length mismatch (expected %d, got %d)\n",
>  			(int)datalen, (int)len);
> -		return -EINVAL;
> +		return -EIO;
>  	}
>  
>  	/* receive the result: */
> @@ -415,7 +415,7 @@ int line6_write_data(struct usb_line6 *line6, u16 address, void *data,
>  		return -EIO;
>  	} else if (status != 0) {
>  		dev_err(line6->ifcdev, "write failed (error %d)\n", ret);
> -		return -EINVAL;
> +		return -EIO;
>  	}
>  
>  	return 0;
> -- 
> 2.1.0
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/