linux-kernel - Re: [PATCH 6/6] ALSA: line6: toneport: Use explicit type for firmware version

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5h4mqs7ph2.wl-tiwai@suse.de>
Date:	Wed, 11 Feb 2015 10:43:37 +0100
From:	Takashi Iwai <tiwai@...e.de>
To:	Chris Rorvick <chris@...vick.com>
Cc:	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
	Stefan Hajnoczi <stefanha@...il.com>
Subject: Re: [PATCH 6/6] ALSA: line6: toneport: Use explicit type for firmware version

At Tue, 10 Feb 2015 23:03:17 -0600,
Chris Rorvick wrote:
> 
> The firmware version is a single byte so have the variable type agree.
> Since the address to this member is passed to the read function, using
> an int is not even portable.
> 
> Signed-off-by: Chris Rorvick <chris@...vick.com>

Applied, thanks.


Takashi

> ---
>  sound/usb/line6/toneport.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/usb/line6/toneport.c b/sound/usb/line6/toneport.c
> index ddf7368..6d4c50c 100644
> --- a/sound/usb/line6/toneport.c
> +++ b/sound/usb/line6/toneport.c
> @@ -52,7 +52,7 @@ struct usb_line6_toneport {
>  	u32 serial_number;
>  
>  	/* Firmware version (x 100) */
> -	int firmware_version;
> +	u8 firmware_version;
>  
>  	/* Timer for delayed PCM startup */
>  	struct timer_list timer;
> -- 
> 2.1.0
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/