linux-kernel - Re: [Patch 2/3] firmware: dmi_scan: fix dmi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKv+Gu9h_E=GCFPokfWpS1AXKfzoSTM3LAt31hwOpJq0SO8XbA@mail.gmail.com>
Date:	Wed, 11 Feb 2015 17:53:02 +0800
From:	Ard Biesheuvel <ard.biesheuvel@...aro.org>
To:	Ivan Khoronzhuk <ivan.khoronzhuk@...aro.org>
Cc:	Matt Fleming <matt.fleming@...el.com>,
	Leif Lindholm <leif.lindholm@...aro.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [Patch 2/3] firmware: dmi_scan: fix dmi_len type

On 11 February 2015 at 17:46, Ivan Khoronzhuk
<ivan.khoronzhuk@...aro.org> wrote:
> According to SMBIOSv3 specification the length of DMI table can be
> up to 32bits wide. So use appropriate type to avoid overflow.
>
> It's obvious that dmi_num theoretically can be more than u16 also,
> so it's can be changed to u32 or at least it's better to use int
> instead of u16, but on that moment I cannot imagine dmi structure
> count more than 65535 and it can require changing type of vars that
> work with it. So I didn't correct it.
>
> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@...aro.org>

Acked-by: Ard Biesheuvel <ard@...aro.org>

This should get a cc stable as well.

-- 
Ard.

> ---
>  drivers/firmware/dmi_scan.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/dmi_scan.c b/drivers/firmware/dmi_scan.c
> index fb16203..952e95c 100644
> --- a/drivers/firmware/dmi_scan.c
> +++ b/drivers/firmware/dmi_scan.c
> @@ -18,7 +18,7 @@
>  static const char dmi_empty_string[] = "        ";
>
>  static u16 __initdata dmi_ver;
> -static u16 dmi_len;
> +static u32 dmi_len;
>  static u16 dmi_num;
>  /*
>   * Catch too early calls to dmi_check_system():
> --
> 1.9.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/