linux-kernel - Re: [PATCH] fs: proc: inode.c: remove unnecessary type cast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 11 Feb 2015 08:02:40 -0600
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	Bas Peters <baspeters93@...il.com>
Cc:	akpm@...ux-foundation.org, oleg@...hat.com, adobriyan@...il.com,
	gorcunov@...nvz.org, viro@...iv.linux.org.uk,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] fs: proc: inode.c: remove unnecessary type cast

Bas Peters <baspeters93@...il.com> writes:

> Issue was detected using Coccinelle.

I believe Al Viro wrote that deliberately.

> Signed-off-by: Bas Peters <baspeters93@...il.com>
> ---
>  fs/proc/inode.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/proc/inode.c b/fs/proc/inode.c
> index 8420a2f..e16ee87 100644
> --- a/fs/proc/inode.c
> +++ b/fs/proc/inode.c
> @@ -57,7 +57,7 @@ static struct inode *proc_alloc_inode(struct super_block *sb)
>  	struct proc_inode *ei;
>  	struct inode *inode;
>  
> -	ei = (struct proc_inode *)kmem_cache_alloc(proc_inode_cachep, GFP_KERNEL);
> +	ei = kmem_cache_alloc(proc_inode_cachep, GFP_KERNEL);
>  	if (!ei)
>  		return NULL;
>  	ei->pid = NULL;

Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/