linux-kernel - Re: [PATCH 3/4] perf inject: add jitdump mmap injection support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 11 Feb 2015 08:27:17 -0700
From:	David Ahern <dsahern@...il.com>
To:	Stephane Eranian <eranian@...gle.com>, linux-kernel@...r.kernel.org
CC:	acme@...hat.com, peterz@...radead.org, mingo@...e.hu,
	ak@...ux.intel.com, jolsa@...hat.com, namhyung@...nel.org,
	cel@...ibm.com, sukadev@...ux.vnet.ibm.com, sonnyrao@...omium.org,
	johnmccutchan@...gle.com
Subject: Re: [PATCH 3/4] perf inject: add jitdump mmap injection support

On 2/10/15 4:42 PM, Stephane Eranian wrote:
> diff --git a/tools/perf/Documentation/perf-inject.txt b/tools/perf/Documentation/perf-inject.txt
> index dc7442c..237f195 100644
> --- a/tools/perf/Documentation/perf-inject.txt
> +++ b/tools/perf/Documentation/perf-inject.txt
> @@ -40,6 +40,17 @@ OPTIONS
>   	Merge sched_stat and sched_switch for getting events where and how long
>   	tasks slept. sched_switch contains a callchain where a task slept and
>   	sched_stat contains a timeslice how long a task slept.
> +-j::
> +--jit::
> +	Merge a jitdump file into the perf.data file by adding mmap records to
> +	cover jitted code and emit ELF images for each jitted function. The ELF
> +	images are saved in the same directory as the jidump. Use -E to suppress
> +	ELF images generation.
> +-E::
> +--jit-disable-elf::
> +	When used with -, it prevents creating the ELF images for each jitted
> +	function. Only the jitted code mmap records are injected into the perf.data
> +	file. Option as no effect when -j is not used.

s/as/has/. But it would better to avoid the double negative. Maye 
something like this instead:

     This option requires -j|--jit.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/