linux-kernel - Re: [PATCH 1/2] block: handle the null_mapped flag correctly in blk_rq_map_user

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <54DB9E0A.7090009@fb.com>
Date:	Wed, 11 Feb 2015 11:23:06 -0700
From:	Jens Axboe <axboe@...com>
To:	Christoph Hellwig <hch@....de>
CC:	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] block: handle the null_mapped flag correctly in blk_rq_map_user_iov

On 02/11/2015 06:07 AM, Christoph Hellwig wrote:
> The tape drivers (and the sg driver in a special case that doesn't matter
> here) use the null_mapped flag to tell blk_rq_map_user to not copy around
> any data into or out of the bounce buffers.  blk_rq_map_user_iov never
> got that treatment, which didn't matter until I refactored blk_rq_map_user
> to be implemented in terms of blk_rq_map_user_iov.

So this fixes a regression caused by:

commit ddad8dd0a162fde61646a627a3017c258601dc8a
Author: Christoph Hellwig <hch@....de>
Date:   Sun Jan 18 16:16:29 2015 +0100

     block: use blk_rq_map_user_iov to implement blk_rq_map_user

     Signed-off-by: Christoph Hellwig <hch@....de>
     Reviewed-by: Ming Lei <tom.leiming@...il.com>
     Signed-off-by: Jens Axboe <axboe@...com>

which we should probably note in the commit. I'll add that.


-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/