linux-kernel - Re: checkpatch induced patches...

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1423687383.15343.22.camel@perches.com>
Date:	Wed, 11 Feb 2015 12:43:03 -0800
From:	Joe Perches <joe@...ches.com>
To:	Pavel Machek <pavel@....cz>
Cc:	Richard Weinberger <richard.weinberger@...il.com>,
	Dan Carpenter <dan.carpenter@...cle.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	gmate.amit@...il.com, Greg KH <gregkh@...uxfoundation.org>,
	Bas Peters <baspeters93@...il.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Pushpendra Singh <pushpendra.singh@...rtplayin.com>,
	manuel.schoelling@....de,
	Sudip Mukherjee <sudipm.mukherjee@...il.com>,
	Kalle Valo <kvalo@....qualcomm.com>
Subject: Re: checkpatch induced patches...

On Wed, 2015-02-11 at 21:24 +0100, Pavel Machek wrote:
> On Wed 2015-02-11 12:20:25, Joe Perches wrote:
> > On Wed, 2015-02-11 at 21:02 +0100, Richard Weinberger wrote:
> > > On Wed, Feb 11, 2015 at 7:36 PM, Dan Carpenter <dan.carpenter@...cle.com> wrote:
> > > > On Wed, Feb 11, 2015 at 10:00:29AM -0800, Joe Perches wrote:
> > > >> I'm half tempted to submit some patch like this to
> > > >> make it difficult to use checkpatch on files outside
> > > >> of drivers/staging.
> > > >> o Only allow checkpatch to be used with the -f/--file
> > > >>   option for drivers/staging/
> > > >> o Add an undocumented --force command line option
> > > > Sure.  We could try that.  I once sent a patch to make -f generate a
> > > > warning about not wasting people's time, but this is also ok.
> > > >> o Make --strict the default for drivers/staging
[]
> > > FYI: We had already a heated debate on that topic.
> > > https://lkml.org/lkml/2014/7/17/415
[]
> > This is basically a patch that implements my suggestion
> > in that thread.
> > https://lkml.org/lkml/2014/7/17/427
> > 
> > I wonder if the undocumented --force option is acceptable
> > to Pavel and Kalle.

> Undocumented options are evil... You can add warning about not wasting
> people's time in --force documentation...

Yeah, I had added --force to the help text
then removed it before sending, so I suppose
adding a warning there is OK too.

Nobody reads the --help text anyway.

Dan/Andrew/Greg?  You got a preference?

Maybe some help/warning text like:

  --force                    Without --force, checkpatch will not scan files
                             using -f or --file outside of drivers/staging/...
                             Do not use this option merely to create potential
                             patches that are uncompiled or untested.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/