linux-kernel - Re: [PATCH][v3.2 stable tree] dcache: Balance rcu_read_lock in have

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150212002850.146cf455@grimm.local.home>
Date:	Thu, 12 Feb 2015 00:28:50 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Ben Hutchings <ben@...adent.org.uk>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	stable <stable@...r.kernel.org>,
	Al Viro <viro@...IV.linux.org.uk>
Subject: Re: [PATCH][v3.2 stable tree] dcache: Balance rcu_read_lock in
 have_submounts()

On Wed, 11 Feb 2015 03:15:37 +0000
Ben Hutchings <ben@...adent.org.uk> wrote:

> I've reviewed locking contexts in all three functions that I changed
> when backporting "deal with deadlock in d_walk()".  It's actually worse
> than you say:
> 
> - We don't hold this_parent->d_lock at the 'positive' label in
> have_submounts(), but it is unlocked after 'rename_retry'.
> - There is an rcu_read_unlock() after the 'out' label in
> select_parent(), but it's not held at the 'goto out'.
> 
> Does the following patch work for you?

I booted the original 3.2 kernel 3 times and it succeeded once, and
crashed the other two.

I applied this patch and booted it 5 times, and it succeeded every time.

I removed the patch, and it crashed on the very next boot.

Thus, I'd say it seems to have fixed the issue for me.

Tested-by: Steven Rostedt <rostedt@...dmis.org>

-- Steve

> 
> Ben.
> 
> --- a/fs/dcache.c
> +++ b/fs/dcache.c
> @@ -1035,7 +1035,7 @@ ascend:
>  	return 0; /* No mount points found in tree */
>  positive:
>  	if (!locked && read_seqretry(&rename_lock, seq))
> -		goto rename_retry;
> +		goto rename_retry_unlocked;
>  	if (locked)
>  		write_sequnlock(&rename_lock);
>  	return 1;
> @@ -1045,6 +1045,7 @@ rename_retry:
>  	rcu_read_unlock();
>  	if (locked)
>  		goto again;
> +rename_retry_unlocked:
>  	locked = 1;
>  	write_seqlock(&rename_lock);
>  	goto again;
> @@ -1109,6 +1110,7 @@ resume:
>  		 */
>  		if (found && need_resched()) {
>  			spin_unlock(&dentry->d_lock);
> +			rcu_read_lock();
>  			goto out;
>  		}
>  
> --- END ---
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/