linux-kernel - Re: [PATCH] Input: sun4i-ts: add thermal driver dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54DC4FD4.4060503@redhat.com>
Date:	Thu, 12 Feb 2015 08:01:40 +0100
From:	Hans de Goede <hdegoede@...hat.com>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Chen-Yu Tsai <wens@...e.org>
CC:	Arnd Bergmann <arnd@...db.de>, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] Input: sun4i-ts: add thermal driver dependency

Hi,

On 11-02-15 19:24, Dmitry Torokhov wrote:
> On Thu, Jan 29, 2015 at 10:51:51AM -0800, Dmitry Torokhov wrote:
>> On Thu, Jan 29, 2015 at 08:50:18AM +0100, Hans de Goede wrote:
>>> Hi,
>>>
>>> On 28-01-15 16:17, Arnd Bergmann wrote:
>>>> The sun4i-ts driver has had a dependency on the thermal code
>>>> since it was first merged,
>>>
>>> The "since it was first merged bit" is not true, this is caused
>>> by recent changes by ChenYu.
>>>
>>> Other then that no objections from me against the proposed fix.
>>>
>>> Regards,
>>>
>>> Hans
>>>
>>>
>>>   but this is not currently enforced
>>>> in Kconfig, so in some randconfig builds we get
>>>>
>>>> drivers/built-in.o: In function `sun4i_ts_remove':
>>>> :(.text+0x2376f4): undefined reference to `thermal_zone_of_sensor_unregister'
>>>> drivers/built-in.o: In function `sun4i_ts_probe':
>>>> :(.text+0x237a94): undefined reference to `thermal_zone_of_sensor_register'
>>>> :(.text+0x237c00): undefined reference to `thermal_zone_of_sensor_unregister'
>>>>
>>>> We need the dependency on THERMAL in order to ensure that this
>>>> driver becomes a loadable module if the thermal support itself
>>>> is modular, while the dependency on THERMAL_OF is a runtime dependency
>>>> and the driver will still build but not work if it is missing.
>>>>
>>>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
>>>> Fixes: 6decea7c5438e2 ("Input: add driver for Allwinner sunxi SoC's rtp controller")
>>>>
>>>> diff --git a/drivers/input/touchscreen/Kconfig b/drivers/input/touchscreen/Kconfig
>>>> index 58917525126e..e2447f0063b7 100644
>>>> --- a/drivers/input/touchscreen/Kconfig
>>>> +++ b/drivers/input/touchscreen/Kconfig
>>>> @@ -943,6 +943,8 @@ config TOUCHSCREEN_SUN4I
>>>>   	tristate "Allwinner sun4i resistive touchscreen controller support"
>>>>   	depends on ARCH_SUNXI || COMPILE_TEST
>>>>   	depends on HWMON
>>>> +	depends on THERMAL
>>>> +	depends on THERMAL_OF || COMPILE_TEST
>>
>> THERMAL_OF does have proper stubs and I do not see why we need to force
>> having TERMAL even if we don't do compile test. Should the dependency be:
>>
>> 	depends on !THERMAL_OF || TERMAL
>
> *ping*

ChenYu, since your patch causes this problem I'm assuming that you will come
up with a fix, is that correct ?

Regards,

Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/