linux-kernel - RE: [Xen-devel] [PATCH] modify the IO_TLB_SEGSIZE to io_tlb_segsize configurable as flexible requirement about SW-IOMMU.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <FA47D36D6EC9FE4CB463299737C09B9901CFE6ED@shsmsx102.ccr.corp.intel.com>
Date:	Thu, 12 Feb 2015 00:55:48 +0000
From:	"Wang, Xiaoming" <xiaoming.wang@...el.com>
To:	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
CC:	David Vrabel <david.vrabel@...rix.com>,
	"linux-mips@...ux-mips.org" <linux-mips@...ux-mips.org>,
	"pebolle@...cali.nl" <pebolle@...cali.nl>,
	"Zhang, Dongxing" <dongxing.zhang@...el.com>,
	"lauraa@...eaurora.org" <lauraa@...eaurora.org>,
	"d.kasatkin@...sung.com" <d.kasatkin@...sung.com>,
	"heiko.carstens@...ibm.com" <heiko.carstens@...ibm.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"ralf@...ux-mips.org" <ralf@...ux-mips.org>,
	"chris@...is-wilson.co.uk" <chris@...is-wilson.co.uk>,
	"takahiro.akashi@...aro.org" <takahiro.akashi@...aro.org>,
	"linux@...izon.com" <linux@...izon.com>,
	"xen-devel@...ts.xenproject.org" <xen-devel@...ts.xenproject.org>,
	"boris.ostrovsky@...cle.com" <boris.ostrovsky@...cle.com>,
	"Liu, Chuansheng" <chuansheng.liu@...el.com>,
	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>
Subject: RE: [Xen-devel] [PATCH] modify the IO_TLB_SEGSIZE to io_tlb_segsize
 configurable as flexible requirement about SW-IOMMU.

Dear Wilk:

> -----Original Message-----
> From: Konrad Rzeszutek Wilk [mailto:konrad.wilk@...cle.com]
> Sent: Thursday, February 12, 2015 4:49 AM
> To: Wang, Xiaoming
> Cc: David Vrabel; linux-mips@...ux-mips.org; pebolle@...cali.nl; Zhang,
> Dongxing; lauraa@...eaurora.org; d.kasatkin@...sung.com;
> heiko.carstens@...ibm.com; linux-kernel@...r.kernel.org; ralf@...ux-
> mips.org; chris@...is-wilson.co.uk; takahiro.akashi@...aro.org;
> linux@...izon.com; xen-devel@...ts.xenproject.org;
> boris.ostrovsky@...cle.com; Liu, Chuansheng; akpm@...ux-foundation.org
> Subject: Re: [Xen-devel] [PATCH] modify the IO_TLB_SEGSIZE to
> io_tlb_segsize configurable as flexible requirement about SW-IOMMU.
> 
> On Wed, Feb 11, 2015 at 08:38:29AM +0000, Wang, Xiaoming wrote:
> > Dear David
> >
> > > -----Original Message-----
> > > From: David Vrabel [mailto:david.vrabel@...rix.com]
> > > Sent: Tuesday, February 10, 2015 5:46 PM
> > > To: Wang, Xiaoming; Konrad Rzeszutek Wilk
> > > Cc: linux-mips@...ux-mips.org; pebolle@...cali.nl; Zhang, Dongxing;
> > > lauraa@...eaurora.org; d.kasatkin@...sung.com;
> > > heiko.carstens@...ibm.com; linux-kernel@...r.kernel.org; ralf@...ux-
> > > mips.org; chris@...is-wilson.co.uk; takahiro.akashi@...aro.org;
> > > david.vrabel@...rix.com; linux@...izon.com; xen-
> > > devel@...ts.xenproject.org; boris.ostrovsky@...cle.com; Liu,
> > > Chuansheng; akpm@...ux-foundation.org
> > > Subject: Re: [Xen-devel] [PATCH] modify the IO_TLB_SEGSIZE to
> > > io_tlb_segsize configurable as flexible requirement about SW-IOMMU.
> > >
> > > On 06/02/15 00:10, Wang, Xiaoming wrote:
> > > >
> > > >
> > > >> -----Original Message-----
> > > >> From: Konrad Rzeszutek Wilk [mailto:konrad.wilk@...cle.com]
> > > >> Sent: Friday, February 6, 2015 3:33 AM
> > > >> To: Wang, Xiaoming
> > > >> Cc: ralf@...ux-mips.org; boris.ostrovsky@...cle.com;
> > > >> david.vrabel@...rix.com; linux-mips@...ux-mips.org; linux-
> > > >> kernel@...r.kernel.org; xen-devel@...ts.xenproject.org;
> > > >> akpm@...ux- foundation.org; linux@...izon.com;
> > > >> lauraa@...eaurora.org; heiko.carstens@...ibm.com;
> > > >> d.kasatkin@...sung.com; takahiro.akashi@...aro.org;
> > > >> chris@...is-wilson.co.uk; pebolle@...cali.nl; Liu, Chuansheng;
> > > >> Zhang, Dongxing
> > > >> Subject: Re: [PATCH] modify the IO_TLB_SEGSIZE to io_tlb_segsize
> > > >> configurable as flexible requirement about SW-IOMMU.
> > > >>
> > > >> On Fri, Feb 06, 2015 at 07:01:14AM +0800, xiaomin1 wrote:
> > > >>> The maximum of SW-IOMMU is limited to 2^11*128 = 256K.
> > > >>> While in different platform and different requirements this
> > > >>> seems
> > > improper.
> > > >>> So modify the IO_TLB_SEGSIZE to io_tlb_segsize as configurable
> > > >>> is make
> > > >> sense.
> > > >>
> > > >> More details please. What is the issue you are hitting?
> > > >>
> > > > Example:
> > > > If 1M bytes are requied. There has an error like.
> > >
> > > Instead of allowing the bouncing of such large buffers, could the
> > > gadget driver be modified to submit the buffers to the hardware in
> smaller chunks?
> > >
> > > David
> >
> > Our target is try to make IO_TLB_SEGSIZE configurable.
> > Neither 256 bytes  or 1M bytes seems suitable value, I think.
> > It's better to use the tactics something like kmem_cache_create  in
> > kmalloc function.
> > But SW-IOMMU seems more lighter.
> > So we choose variable rather than function.
> 
> Would it be possible to understand why the gadget needs such large buffer?
> That is irrespective of the patchset you are proposing.
> 
> In regards to the pathchset - I don't see anything fundamentally wrong with
> the patch. What I am afraid is that this fixes the symptoms instead of the
> underlaying problem. The problem I think is that with this large 1MB requests
> you risk of using the SWIOTLB bounce buffer which can result in poor
> performance.
> 
> So eventually somebody will have to figure out why the performance is poor
> and have a hard time figuring what is wrong - as the symptoms have been
> removed.
> 
> Hence looking at potentially using an scatter gather mechanism and chop up
> the requests in smaller sizes might be an better option. But I don't know?
> Perhaps you are more familiar with the gadget and could tell me why it needs
> an 1MB size request?
> 
> 
The 1M size is requested when doing flash fastboot in 
system/core/fastbootd/commands/flash.c  defined by Google.
I listed a partial code from flash.c  here.
#define BUFFER_SIZE 1024 * 1024
int current_size = MIN(size - written, BUFFER_SIZE);
(gpt_mmap(&input, written + skip, current_size, data_fd))
mapping->size = ALIGN(size + location_diff, PAGE_SIZE);

> >
> > Xiaoming.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/