linux-kernel - Re: [PATCH] ASoC: omap-hdmi-audio: Add missing error check for devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 12 Feb 2015 11:22:41 +0200
From:	Peter Ujfalusi <peter.ujfalusi@...com>
To:	Kiran Padwal <kiran.padwal@...rtplayin.com>,
	Mark Brown <broonie@...nel.org>
CC:	Liam Girdwood <lgirdwood@...il.com>,
	Jarkko Nikula <jarkko.nikula@...mer.com>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.de>,
	<linux-omap@...r.kernel.org>, <alsa-devel@...a-project.org>,
	<linux-kernel@...r.kernel.org>,
	Kiran Padwal <kiran.padwal21@...il.com>,
	"Sarha, Jyri" <jsarha@...com>
Subject: Re: [PATCH] ASoC: omap-hdmi-audio: Add missing error check for devm_kzalloc

On 02/12/2015 11:08 AM, Kiran Padwal wrote:
> This patch add a missing check on the return value of devm_kzalloc,
> which would cause a NULL pointer dereference in a OOM situation.

Acked-by: Peter Ujfalusi <peter.ujfalusi@...com>

> 
> Signed-off-by: Kiran Padwal <kiran.padwal@...rtplayin.com>
> ---
>  sound/soc/omap/omap-hdmi-audio.c |    3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/sound/soc/omap/omap-hdmi-audio.c b/sound/soc/omap/omap-hdmi-audio.c
> index ccfb41c..f7eb42a 100644
> --- a/sound/soc/omap/omap-hdmi-audio.c
> +++ b/sound/soc/omap/omap-hdmi-audio.c
> @@ -352,6 +352,9 @@ static int omap_hdmi_audio_probe(struct platform_device *pdev)
>  		return ret;
>  
>  	card = devm_kzalloc(dev, sizeof(*card), GFP_KERNEL);
> +	if (!card)
> +		return -ENOMEM;
> +
>  	card->name = devm_kasprintf(dev, GFP_KERNEL,
>  				    "HDMI %s", dev_name(ad->dssdev));
>  	card->owner = THIS_MODULE;
> 


-- 
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/