linux-kernel - Re: [PATCH] PM-Trace: add pm-trace support for suspending phase

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150212012339.GE28271@kroah.com>
Date:	Thu, 12 Feb 2015 09:23:39 +0800
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	"Fu, Zhonghui" <zhonghui.fu@...ux.intel.com>
Cc:	"Rafael J. Wysocki" <rjw@...ysocki.net>, pavel@....cz,
	len.brown@...el.com, linux-pm@...r.kernel.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] PM-Trace: add pm-trace support for suspending phase

On Wed, Feb 11, 2015 at 10:43:13PM +0800, Fu, Zhonghui wrote:
> >From 2626594c03ca3b9884dd44073385c36f99a3651d Mon Sep 17 00:00:00 2001
> From: Zhonghui Fu <zhonghui.fu@...ux.intel.com>
> Date: Wed, 11 Feb 2015 16:20:21 +0800
> Subject: [PATCH] PM-Trace: add pm-trace support for suspending phase
> 
> Occasionally, the system can't come back up after suspend/resume
> due to problems of device suspending phase. This patch make
> PM_TRACE infrastructure cover device suspending phase of
> suspend/resume process, and the information in RTC can tell
> developers which device suspending function make system hang.
> 
> Signed-off-by: Zhonghui Fu <zhonghui.fu@...ux.intel.com>
> ---
>  arch/x86/include/asm/pm-trace.h     |   36 +++++++++++++++++++++++++++++++++++
>  arch/x86/include/asm/resume-trace.h |   21 --------------------
>  drivers/base/power/main.c           |   20 +++++++++++++++---
>  drivers/base/power/trace.c          |    6 ++--
>  include/linux/pm-trace.h            |   35 ++++++++++++++++++++++++++++++++++
>  include/linux/resume-trace.h        |   34 ---------------------------------
>  kernel/power/main.c                 |    2 +-
>  7 files changed, 91 insertions(+), 63 deletions(-)
>  create mode 100644 arch/x86/include/asm/pm-trace.h
>  delete mode 100644 arch/x86/include/asm/resume-trace.h
>  create mode 100644 include/linux/pm-trace.h
>  delete mode 100644 include/linux/resume-trace.h

Please create patches that move files around with -M so that the rename
and changes can be reviewed much easier.  As it is, I can't see the
changes you have made here.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/