linux-kernel - Re: [V3 PATCH 1/2] ACPI / scan: Add support for ACPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 12 Feb 2015 12:51:39 +0200
From:	Mika Westerberg <mika.westerberg@...ux.intel.com>
To:	"Suthikulpanit, Suravee" <Suravee.Suthikulpanit@....com>
Cc:	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"lenb@...nel.org" <lenb@...nel.org>,
	"hdegoede@...hat.com" <hdegoede@...hat.com>,
	"tj@...nel.org" <tj@...nel.org>, "arnd@...db.de" <arnd@...db.de>,
	"mjg59@...f.ucam.org" <mjg59@...f.ucam.org>,
	"grant.likely@...aro.org" <grant.likely@...aro.org>,
	"hanjun.guo@...aro.org" <hanjun.guo@...aro.org>,
	"al.stone@...aro.org" <al.stone@...aro.org>,
	"graeme.gregory@...aro.org" <graeme.gregory@...aro.org>,
	"Duran, Leo" <leo.duran@....com>,
	"linux-ide@...r.kernel.org" <linux-ide@...r.kernel.org>,
	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linaro-acpi@...ts.linaro.org" <linaro-acpi@...ts.linaro.org>,
	Lv Zheng <lv.zheng@...el.com>
Subject: Re: [V3 PATCH 1/2] ACPI / scan: Add support for ACPI _CLS device
 matching

On Wed, Feb 11, 2015 at 10:35:25PM +0000, Suthikulpanit, Suravee wrote:
> >> Besides, how do you support modules with this? Or did I miss something?
> >
> >Good question.
> 
> Ah. I didn¹t think about this part earlier.
> 
> IIUC, the current ACPI driver would create modules.alias entry with format:
> 	acpi:<HID>:<CID>
> 
> What do you think if we append the _CLS of the device using the following
> format:
> 	acpi:<HID>:<CID>:<CLS>
> 
> In case of PCI_CLASS_STORAGE_SATA_AHCI, this would become:
> 	acpi:::0x10601

Note, that you can have multiple _CIDs, in other words it may look like:

	acpi:<HID>:<CID0>:<CID1>:<CLS>

In which case I'm not sure how to match the class. Perhaps use something
else than ':' as a separator for class?

BTW, should we add class_mask as well (like PCI does) so that drivers
can match part of the class id?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/