linux-kernel - Re: [PATCH v2] ARM: dts: zynq: Add OCM node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150212105443.GB1522@leverpostej>
Date:	Thu, 12 Feb 2015 10:54:44 +0000
From:	Mark Rutland <mark.rutland@....com>
To:	Michal Simek <michal.simek@...inx.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"monstr@...str.eu" <monstr@...str.eu>,
	Andreas Färber <afaerber@...e.de>,
	Sören Brinkmann <soren.brinkmann@...inx.com>,
	Russell King <linux@....linux.org.uk>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	Steffen Trumtrar <s.trumtrar@...gutronix.de>,
	Kumar Gala <galak@...eaurora.org>,
	Peter Crosthwaite <peter.crosthwaite@...inx.com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <Pawel.Moll@....com>,
	Rob Herring <robherring2@...il.com>,
	Josh Cartwright <josh.cartwright@...com>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v2] ARM: dts: zynq: Add OCM node

On Thu, Feb 12, 2015 at 10:42:47AM +0000, Michal Simek wrote:
> Add OCM node for all zynq boards. OCM location
> can changed but for all current boards this
> is the location where OCM is.`
> 
> Signed-off-by: Michal Simek <michal.simek@...inx.com>
> ---
> 
> Changes in v2:
> - Move node to board file suggested by Mark
> 
> This patch is done based on discussion here.
> https://lkml.org/lkml/2014/12/1/396
> 
> Mark: I expect you won't like amba bus reference or
> am I wrong?

I'm fine with dropping things onto a bus in this way. If we're happy to
do it for other nodes I don't see why busses should be special.

Mark.

> 
> ---
>  arch/arm/boot/dts/zynq-7000.dtsi | 2 +-
>  arch/arm/boot/dts/zynq-zc702.dts | 7 +++++++
>  2 files changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/zynq-7000.dtsi b/arch/arm/boot/dts/zynq-7000.dtsi
> index a5cd2eda3edf..acca3c180324 100644
> --- a/arch/arm/boot/dts/zynq-7000.dtsi
> +++ b/arch/arm/boot/dts/zynq-7000.dtsi
> @@ -57,7 +57,7 @@
>  		regulator-always-on;
>  	};
>  
> -	amba {
> +	amba: amba {
>  		compatible = "simple-bus";
>  		#address-cells = <1>;
>  		#size-cells = <1>;
> diff --git a/arch/arm/boot/dts/zynq-zc702.dts b/arch/arm/boot/dts/zynq-zc702.dts
> index fb59d34e8ee6..79077c5ac60e 100644
> --- a/arch/arm/boot/dts/zynq-zc702.dts
> +++ b/arch/arm/boot/dts/zynq-zc702.dts
> @@ -50,6 +50,13 @@
>  	};
>  };
>  
> +&amba {
> +	ocm: sram@...c0000 {
> +		compatible = "mmio-sram";
> +		reg = <0xfffc0000 0x10000>;
> +	};
> +};
> +
>  &can0 {
>  	status = "okay";
>  	pinctrl-names = "default";
> -- 
> 1.8.2.3
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/