lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 12 Feb 2015 13:03:18 +0200 From: "Kirill A. Shutemov" <kirill@...temov.name> To: David Rientjes <rientjes@...gle.com> Cc: "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>, Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org, linux-kernel@...r.kernel.org, Linus Torvalds <torvalds@...ux-foundation.org>, Michel Lespinasse <walken@...gle.com>, Rik van Riel <riel@...hat.com> Subject: Re: [PATCH 2/4] mm: rename __mlock_vma_pages_range() to populate_vma_page_range() On Wed, Feb 11, 2015 at 11:59:33AM -0800, David Rientjes wrote: > On Wed, 11 Feb 2015, Kirill A. Shutemov wrote: > > > __mlock_vma_pages_range() doesn't necessary mlock pages. It depends on > > vma flags. The same codepath is used for MAP_POPULATE. > > > > s/necessary/necessarily/ > > > Let's rename __mlock_vma_pages_range() to populate_vma_page_range(). > > > > This patch also drops mlock_vma_pages_range() references from > > documentation. It has gone in commit cea10a19b797. > > > > Signed-off-by: Kirill A. Shutemov <kirill.shutemov@...ux.intel.com> > > I think it makes sense to drop the references about "downgrading" > mm->mmap_sem in the documentation since populate_vma_page_range() can be > called with it held either for read or write depending on the context. I'm not sure what references you're talking about. Is it about this part: * If @nonblocking is non-NULL, it must held for read only and may be * released. If it's released, *@...blocking will be set to 0. ? The comment is still true as far as I can say. It comes from up_read() in __lock_page_or_retry(). -- Kirill A. Shutemov -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists