linux-kernel - Re: [PATCH 1/4] perf tools: add Java demangling support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150212112704.GB2933@krava.brq.redhat.com>
Date:	Thu, 12 Feb 2015 12:27:04 +0100
From:	Jiri Olsa <jolsa@...hat.com>
To:	Stephane Eranian <eranian@...gle.com>
Cc:	linux-kernel@...r.kernel.org, acme@...hat.com,
	peterz@...radead.org, mingo@...e.hu, ak@...ux.intel.com,
	namhyung@...nel.org, cel@...ibm.com, sukadev@...ux.vnet.ibm.com,
	sonnyrao@...omium.org, johnmccutchan@...gle.com
Subject: Re: [PATCH 1/4] perf tools: add Java demangling support

On Wed, Feb 11, 2015 at 12:42:42AM +0100, Stephane Eranian wrote:
> Add Java function descriptor demangling support.
> Something bfd cannot do.
> 

SNIP

> +	}
> +	buf[rlen] = '\0';
> +	return buf;
> +error:
> +	return NULL;
> +}
> +
> +/*
> + * Demangle Java function signature (Hotspot, not GCJ)
> + * input:
> + * 	str: string to parse. String is not modified
> + * return:
> + *	if can demangle then a a newly allocate string is returned.
> + *	if cannot demangle, then NULL is returned
> + *
> + * Note that caller is responsible for freeing demangled string
> + */
> +char *
> +java_demangle_sym(const char *str)
> +{

This seem fairly separated functionality, could you please
move it into new object?

Also could you please document in more details requested
input and produced output strings of this function?

It's nice function to have automated test that translates
strings and verify expected output. IMO it'd help documenting
the function as well.

thanks,
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/