linux-kernel - Re: [PATCH] quota: paranoia: check quota tree root

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150212140406.GB12905@quack.suse.cz>
Date:	Thu, 12 Feb 2015 15:04:06 +0100
From:	Jan Kara <jack@...e.cz>
To:	Konstantin Khlebnikov <khlebnikov@...dex-team.ru>
Cc:	linux-fsdevel@...r.kernel.org, Jan Kara <jack@...e.cz>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] quota: paranoia: check quota tree root

On Thu 12-02-15 12:36:49, Konstantin Khlebnikov wrote:
> Root level in quota tree must be already allocated otherwise this block
> could be used for something else.
  Thanks. I've added the patch to my tree.

							Honza

> 
> Signed-off-by: Konstantin Khlebnikov <khlebnikov@...dex-team.ru>
> ---
>  fs/quota/quota_tree.c |    7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/fs/quota/quota_tree.c b/fs/quota/quota_tree.c
> index d65877f..58efb83 100644
> --- a/fs/quota/quota_tree.c
> +++ b/fs/quota/quota_tree.c
> @@ -349,6 +349,13 @@ static inline int dq_insert_tree(struct qtree_mem_dqinfo *info,
>  				 struct dquot *dquot)
>  {
>  	int tmp = QT_TREEOFF;
> +
> +#ifdef __QUOTA_QT_PARANOIA
> +	if (info->dqi_blocks <= QT_TREEOFF) {
> +		quota_error(dquot->dq_sb, "Quota tree root isn't allocated!");
> +		return -EIO;
> +	}
> +#endif
>  	return do_insert_tree(info, dquot, &tmp, 0);
>  }
>  
> 
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/