linux-kernel - Re: [PATCH 1/2] [media] am437x: VIDEO_AM437X_VPFE should depend on HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+V-a8tycP5BVQuYP-5i6NyPkht3xQx+UVrRsNxg5QK0bbMv+w@mail.gmail.com>
Date:	Thu, 12 Feb 2015 14:30:58 +0000
From:	"Lad, Prabhakar" <prabhakar.csengg@...il.com>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	Mauro Carvalho Chehab <mchehab@....samsung.com>,
	Hans Verkuil <hans.verkuil@...co.com>,
	Arnd Bergmann <arnd@...db.de>,
	linux-media <linux-media@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] [media] am437x: VIDEO_AM437X_VPFE should depend on HAS_DMA

On Thu, Feb 12, 2015 at 2:11 PM, Geert Uytterhoeven
<geert@...ux-m68k.org> wrote:
> If NO_DMA=y:
>
>     warning: (VIDEO_AM437X_VPFE && VIDEO_DM365_VPFE && VIDEO_DT3155 && VIDEO_OMAP4) selects VIDEOBUF2_DMA_CONTIG which has unmet direct dependencies (MEDIA_SUPPORT && HAS_DMA)
>
>     drivers/media/v4l2-core/videobuf2-dma-contig.c: In function ‘vb2_dc_mmap’:
>     drivers/media/v4l2-core/videobuf2-dma-contig.c:207: error: implicit declaration of function ‘dma_mmap_coherent’
>     drivers/media/v4l2-core/videobuf2-dma-contig.c: In function ‘vb2_dc_get_base_sgt’:
>     drivers/media/v4l2-core/videobuf2-dma-contig.c:390: error: implicit declaration of function ‘dma_get_sgtable’
>
> VIDEO_AM437X_VPFE selects VIDEOBUF2_DMA_CONTIG, which bypasses its
> dependency on HAS_DMA.  Make VIDEO_AM437X_VPFE depend on HAS_DMA to fix
> this.
>
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>

Acked-by: Lad, Prabhakar <prabhakar.csengg@...il.com>

Regards,
--Prabhakar Lad

> ---
>  drivers/media/platform/am437x/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/am437x/Kconfig b/drivers/media/platform/am437x/Kconfig
> index 7b023a76e32ebabc..42d9c186710a6423 100644
> --- a/drivers/media/platform/am437x/Kconfig
> +++ b/drivers/media/platform/am437x/Kconfig
> @@ -1,6 +1,6 @@
>  config VIDEO_AM437X_VPFE
>         tristate "TI AM437x VPFE video capture driver"
> -       depends on VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API
> +       depends on VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API && HAS_DMA
>         depends on SOC_AM43XX || COMPILE_TEST
>         select VIDEOBUF2_DMA_CONTIG
>         help
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/