[<prev] [next>] [day] [month] [year] [list]
Message-ID: <d03fe504acc343878cd4b8f42aecac09@BL2FFO11FD038.protection.gbl>
Date: Thu, 12 Feb 2015 16:00:06 +0100
From: Michal Simek <michal.simek@...inx.com>
To: Sören Brinkmann <soren.brinkmann@...inx.com>,
"Michal Simek" <michal.simek@...inx.com>
CC: Mark Rutland <mark.rutland@....com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"monstr@...str.eu" <monstr@...str.eu>,
Andreas Färber <afaerber@...e.de>,
Russell King <linux@....linux.org.uk>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
Steffen Trumtrar <s.trumtrar@...gutronix.de>,
Kumar Gala <galak@...eaurora.org>,
Peter Crosthwaite <peter.crosthwaite@...inx.com>,
Ian Campbell <ijc+devicetree@...lion.org.uk>,
Rob Herring <robh+dt@...nel.org>,
Pawel Moll <Pawel.Moll@....com>,
Rob Herring <robherring2@...il.com>,
Josh Cartwright <josh.cartwright@...com>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v2] ARM: dts: zynq: Add OCM node
On 02/12/2015 03:58 PM, Sören Brinkmann wrote:
> On Thu, 2015-02-12 at 12:01PM +0100, Michal Simek wrote:
>> On 02/12/2015 11:54 AM, Mark Rutland wrote:
>>> On Thu, Feb 12, 2015 at 10:42:47AM +0000, Michal Simek wrote:
>>>> Add OCM node for all zynq boards. OCM location
>>>> can changed but for all current boards this
>>>> is the location where OCM is.`
>>>>
>>>> Signed-off-by: Michal Simek <michal.simek@...inx.com>
>>>> ---
>>>>
>>>> Changes in v2:
>>>> - Move node to board file suggested by Mark
>>>>
>>>> This patch is done based on discussion here.
>>>> https://lkml.org/lkml/2014/12/1/396
>>>>
>>>> Mark: I expect you won't like amba bus reference or
>>>> am I wrong?
>>>
>>> I'm fine with dropping things onto a bus in this way. If we're happy to
>>> do it for other nodes I don't see why busses should be special.
>>
>> Wonderful. I will give people some time to comment this style.
>
> Given that the location is discoverable, wouldn't it make sense to let
> 'reg' point to the ctrl/cfg registers in the SLCR and let the driver
> handle the whereabouts of the OCM location? (but I guess this is going
> in circles now, such a proposal was on the table at some point, IIRC).
> But I'd prefer:
> memory-controller@...ffc0000 { /* the address here would of course not match all configurations */
> interrupts = ...;
> syscon = &slcr;
> };
That was discussed with Arnd at that link above.
Thanks,
Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists