linux-kernel - Re: [PATCH v2 1/3] clk: Don't dereference parent clock if is NULL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54DCF840.60709@codeaurora.org>
Date:	Thu, 12 Feb 2015 11:00:16 -0800
From:	Stephen Boyd <sboyd@...eaurora.org>
To:	Javier Martinez Canillas <javier.martinez@...labora.co.uk>,
	Mike Turquette <mturquette@...aro.org>
CC:	Tomeu Vizoso <tomeu.vizoso@...labora.com>,
	Emilio López 
	<emilio@...pez.com.ar>,
	Peter De Schrijver <pdeschrijver@...dia.com>,
	Robert Jarzmik <robert.jarzmik@...e.fr>,
	Giuseppe Cavallaro <peppe.cavallaro@...com>,
	linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/3] clk: Don't dereference parent clock if is NULL

On 02/12/15 05:58, Javier Martinez Canillas wrote:
> The clock passed as an argument to clk_mux_determine_rate_flags()
> has the CLK_SET_RATE_PARENT flag set but it has no parent, then a
> NULL pointer will tried to be dereferenced.
>
> This shouldn't happen since setting that flag for a clock with no
> parent is a bug but the core should be robust to handle that case.
>
> Fixes: 035a61c314eb3 ("clk: Make clk API return per-user struct clk instances")
> Signed-off-by: Javier Martinez Canillas <javier.martinez@...labora.co.uk>

Reviewed-by: Stephen Boyd <sboyd@...eaurora.org>

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/