lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <1423773026-5941-1-git-send-email-ross.zwisler@linux.intel.com>
Date:	Thu, 12 Feb 2015 13:30:26 -0700
From:	Ross Zwisler <ross.zwisler@...ux.intel.com>
To:	linux-kernel@...r.kernel.org
Cc:	Ross Zwisler <ross.zwisler@...ux.intel.com>,
	Lauri Kasanen <cand@....com>,
	Christian König <christian.koenig@....com>,
	Dave Airlie <airlied@...hat.com>,
	Alex Deucher <alexander.deucher@....com>,
	dri-devel@...ts.freedesktop.org
Subject: [PATCH] drm/radeon: Fix regression with suspend/resume

This patch reverts the changes made in this commit:

  deadcb36f49b ("drm/radeon: Use two-ended allocation by size, v2")

That patch caused a regression on my system where the bottom of the
screen flickers after my laptop goes thorough a suspend and resume.
This is reproducible 100% of the time.

This patch applies cleanly to v3.19, and fixes the screen flicker issue
on my system.  Here is the hardware that I'm using (from lspci):

01:00.0 VGA compatible controller: Advanced Micro Devices, Inc.
[AMD/ATI] Seymour [Radeon HD 6400M/7400M Series]

Signed-off-by: Ross Zwisler <ross.zwisler@...ux.intel.com>
Cc: Lauri Kasanen <cand@....com>
Cc: "Christian König" <christian.koenig@....com>
Cc: Dave Airlie <airlied@...hat.com>
Cc: Alex Deucher <alexander.deucher@....com>
Cc: dri-devel@...ts.freedesktop.org
---
 drivers/gpu/drm/radeon/radeon_object.c | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/drivers/gpu/drm/radeon/radeon_object.c b/drivers/gpu/drm/radeon/radeon_object.c
index 86fc564..dea1baf 100644
--- a/drivers/gpu/drm/radeon/radeon_object.c
+++ b/drivers/gpu/drm/radeon/radeon_object.c
@@ -173,17 +173,6 @@ void radeon_ttm_placement_from_domain(struct radeon_bo *rbo, u32 domain)
 		else
 			rbo->placements[i].lpfn = 0;
 	}
-
-	/*
-	 * Use two-ended allocation depending on the buffer size to
-	 * improve fragmentation quality.
-	 * 512kb was measured as the most optimal number.
-	 */
-	if (rbo->tbo.mem.size > 512 * 1024) {
-		for (i = 0; i < c; i++) {
-			rbo->placements[i].flags |= TTM_PL_FLAG_TOPDOWN;
-		}
-	}
 }
 
 int radeon_bo_create(struct radeon_device *rdev,
-- 
1.9.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ