linux-kernel - Re: [PATCH] rc: st_rc: Use CONFIG_PM_SLEEP instead of CONFIG_PM for st_rc_suspend() and st_rc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <54DD21AB.8070700@sunrus.com.cn>
Date:	Fri, 13 Feb 2015 05:56:59 +0800
From:	Chen Gang S <gang.chen@...rus.com.cn>
To:	Patrice Chotard <patrice.chotard@...com>,
	srinivas.kandagatla@...il.com, maxime.coquelin@...com,
	mchehab@....samsung.com
CC:	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>, kernel@...inux.com,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] rc: st_rc: Use CONFIG_PM_SLEEP instead of CONFIG_PM for
 st_rc_suspend() and st_rc_resume()

Hello Maintainers:

Please help to process this patch, when you have time.

Thanks.

On 2/2/15 15:54, Patrice Chotard wrote:
> Hi Chen
> 
> On 02/01/2015 03:42 PM, Chen Gang S wrote:
>> st_rc_suspend() and st_rc_resume() depend on CONFIG_PM_SLEEP finally, so
>> they need CONFIG_PM_SLEEP instead of CONFIG_PM, or they will cause build
>> warning (with allmodconfig under xtensa):
>>
>>      CC [M]  drivers/media/pci/smipcie/smipcie.o
>>    drivers/media/rc/st_rc.c:338:12: warning: 'st_rc_suspend' defined but not used [-Wunused-function]
>>     static int st_rc_suspend(struct device *dev)
>>                ^
>>    drivers/media/rc/st_rc.c:359:12: warning: 'st_rc_resume' defined but not used [-Wunused-function]
>>     static int st_rc_resume(struct device *dev)
>>                ^
>>
>> Signed-off-by: Chen Gang <gang.chen.5i5j@...il.com>
>> ---
>>   drivers/media/rc/st_rc.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/media/rc/st_rc.c b/drivers/media/rc/st_rc.c
>> index 0e758ae..fbfe958 100644
>> --- a/drivers/media/rc/st_rc.c
>> +++ b/drivers/media/rc/st_rc.c
>> @@ -334,7 +334,7 @@ err:
>>       return ret;
>>   }
>>   -#ifdef CONFIG_PM
>> +#ifdef CONFIG_PM_SLEEP
>>   static int st_rc_suspend(struct device *dev)
>>   {
>>       struct st_rc_device *rc_dev = dev_get_drvdata(dev);
> 
> Acked-by: Patrice Chotard <patrice.chotard@...com>
> 


Thanks.
-- 
Chen Gang

Open, share, and attitude like air, water, and life which God blessed
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/