linux-kernel - Re: [GIT PULL] Backing device changes for 3.20

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150213093746.1507f01e@canb.auug.org.au>
Date:	Fri, 13 Feb 2015 09:37:46 +1100
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Jens Axboe <axboe@...com>,
	Trond Myklebust <trond.myklebust@...marydata.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Linux NFS Mailing List <linux-nfs@...r.kernel.org>
Subject: Re: [GIT PULL] Backing device changes for 3.20

Hi All,

On Thu, 12 Feb 2015 14:05:00 -0800 Linus Torvalds <torvalds@...ux-foundation.org> wrote:
>
> On Thu, Feb 12, 2015 at 12:38 PM, Jens Axboe <axboe@...com> wrote:
> >
> > This pull request contains a cleanup of how the backing device is
> > handled, in preparation for a rework of the life time rules. In this
> > part, the most important change is to split the unrelated nommu mmap
> > flags from it, but also removing a backing_dev_info pointer from the
> > address_space (and inode), and a cleanup of other various minor bits.
> 
> Ugh, so this has a semantic conflict with the NFS client, that has
> this particular code:
> 
>         if (!cinfo->dreq) {
>                 inc_zone_page_state(req->wb_page, NR_UNSTABLE_NFS);
> -               inc_bdi_stat(page_file_mapping(req->wb_page)->backing_dev_info,
> +
> inc_bdi_stat(inode_to_bdi(page_file_mapping(req->wb_page)->host),
>                              BDI_RECLAIMABLE);
>                 __mark_inode_dirty(req->wb_context->dentry->d_inode,
>                                    I_DIRTY_DATASYNC);
>         }
> 
> duplicated several times, and now one more time in the new
> fs/nfs/flexfilelayout/flexfilelayout.c file.

Sometime I wonder why I bother pointing these things out in
linux-next :-(  Ah, well.

(Trond did mention it in his pull request, but it wasn't a problem
then.)

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au

Content of type "application/pgp-signature" skipped