linux-kernel - Re: [PATCH 1/8] usb: add bus type for USB ULPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 13 Feb 2015 13:24:57 +0200
From:	Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To:	Stephen Boyd <sboyd@...eaurora.org>
Cc:	Felipe Balbi <balbi@...com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Baolu Lu <baolu.lu@...ux.intel.com>, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/8] usb: add bus type for USB ULPI

On Thu, Feb 12, 2015 at 05:44:20PM -0800, Stephen Boyd wrote:
> On 01/23/15 07:12, Heikki Krogerus wrote:
> > diff --git a/scripts/mod/file2alias.c b/scripts/mod/file2alias.c
> > index e614ef6..753cb08 100644
> > --- a/scripts/mod/file2alias.c
> > +++ b/scripts/mod/file2alias.c
> > @@ -1176,6 +1176,19 @@ static int do_rio_entry(const char *filename,
> >  }
> >  ADD_TO_DEVTABLE("rapidio", rio_device_id, do_rio_entry);
> >  
> > +/* Looks like: mei:S */
> 
> This comment doesn't look right.

Oops. Thanks for catching that one.

> > +static int do_ulpi_entry(const char *filename, void *symval,
> > +			 char *alias)
> > +{
> > +	DEF_FIELD(symval, ulpi_device_id, vendor);
> > +	DEF_FIELD(symval, ulpi_device_id, product);
> > +
> > +	sprintf(alias, "ulpi:v%04xp%04x", vendor, product);
> > +
> > +	return 1;
> > +}
> > +ADD_TO_DEVTABLE("ulpi", ulpi_device_id, do_ulpi_entry);


-- 
heikki
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/