linux-kernel - Re: [PATCH 1/2]Trivial patch: to solve indentation warnings in amba-clcd.c driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150213120319.GX8656@n2100.arm.linux.org.uk>
Date:	Fri, 13 Feb 2015 12:03:19 +0000
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	Joe Perches <joe@...ches.com>
Cc:	Parmeshwr Prasad <parmeshwr_prasad@...l.com>,
	plagnioj@...osoft.com, tomi.valkeinen@...com, trivial@...nel.org,
	linux-fbdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2]Trivial patch: to solve indentation warnings in
 amba-clcd.c driver

On Fri, Feb 13, 2015 at 03:59:56AM -0800, Joe Perches wrote:
> Perhaps this could be better as:
> 
> 	fb->fb.fix.smem_start =
> 		 of_translate_address(memory,
> 				      of_get_address(memory, 0, &size, NULL));
> 
> But sometimes using multiple statements instead of
> embedding function calls as arguments can be simpler
> and more intelligible for the reader.
> 
> 	__be32 addr;
> 
> 	...
> 
> 	addr = of_get_address(memory, 0, &size, NULL);
> 	fb->fb.fix.smem_start = of_translate_address(memory, addr);

Yes, that would be a better solution, thanks.

-- 
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/