linux-kernel - Re: [GIT PULL] x86/apic updates for v3.20

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFyQQ_nRmguHWoVVBOWQduunQfxoBCgDE0a2gU=_5jo2JQ@mail.gmail.com>
Date:	Thu, 12 Feb 2015 18:08:45 -0800
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	Jiang Liu <jiang.liu@...ux.intel.com>,
	Joerg Roedel <joro@...tes.org>
Cc:	Ingo Molnar <mingo@...nel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [GIT PULL] x86/apic updates for v3.20

On Thu, Feb 12, 2015 at 6:06 PM, Rafael J. Wysocki <rjw@...ysocki.net> wrote:
>
> FWIW, I have a revert in my tree which is related to broken suspend.  Commits
> to revert are e06bf91b59d3 and 37d11391c2de in this order.
>
> I'll be sending a pull request with that tomorrow.

It's neither of those for me. It's:

  5fcee53ce705d49c766f8a302c7e93bdfc33c124 is the first bad commit
  commit 5fcee53ce705d49c766f8a302c7e93bdfc33c124
  Author: Jiang Liu <jiang.liu@...ux.intel.com>
  Date:   Wed Jan 7 15:31:38 2015 +0800

      x86/apic: Only disable CPU x2apic mode when necessary

according to my bisect.

Jiang, Joerg - that commit seems to cause a lockup at suspend time for
me. Now, I haven't verified by reverting it from top-of-git yet, but
the bisection seemed to be pretty stable. I'll try the revert next (it
doesn't revert cleanly, but I can undo it by hand).

Any ideas? The Pixel Chromebook does have an odd and often broken
BIOS/firmware thing, but it *used* to suspend and resume very reliably
once we got around its insane TPM thing.

                   Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/