linux-kernel - Re: [PATCH] MIPS: mm: Remove dead macro definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.11.1502131949190.22715@eddie.linux-mips.org>
Date:	Fri, 13 Feb 2015 19:50:18 +0000 (GMT)
From:	"Maciej W. Rozycki" <macro@...ux-mips.org>
To:	Andreas Ruprecht <rupran@...server.de>
cc:	Ralf Baechle <ralf@...ux-mips.org>, linux-mips@...ux-mips.org,
	linux-kernel@...r.kernel.org,
	Valentin Rothberg <valentinrothberg@...il.com>,
	Paul Bolle <pebolle@...cali.nl>
Subject: Re: [PATCH] MIPS: mm: Remove dead macro definitions

On Thu, 12 Feb 2015, Andreas Ruprecht wrote:

> In commit c441d4a54c6e ("MIPS: mm: Only build one microassembler that
> is suitable"), the Makefile at arch/mips/mm was rewritten to only
> build the "right" microassembler file, depending on whether
> CONFIG_CPU_MICROMIPS is set or not.
> 
> In the files, however, there are still preprocessor definitions
> depending on CONFIG_CPU_MICROMIPS. The #ifdef around them can now
> never evaluate to true, so let's remove them altogether.
> 
> This inconsistency was found using the undertaker-checkpatch tool.
> 
> Signed-off-by: Andreas Ruprecht <rupran@...server.de>
> ---

Reviewed-by: Maciej W. Rozycki <macro@...ux-mips.org>

 Thanks for catching it!

  Maciej
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/