linux-kernel - Re: [PATCH 1/1] Staging: gdm724x: code style improvements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALmu+SxGziVr72RLAfmeZGupvy0hX=4pH2cKy7c2RB5tTvgkcA@mail.gmail.com>
Date:	Fri, 13 Feb 2015 14:07:39 -0800
From:	Tolga Ceylan <tolga.ceylan@...il.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"David S. Miller" <davem@...emloft.net>,
	Dilek Uzulmez <dilekuzulmez@...il.com>,
	Ning Zhou <zhou.ning.gd@...il.com>,
	Gulsah Kose <gulsah.1004@...il.com>,
	Tom Gundersen <teg@...m.no>, Scott Weir <sjw0410@...il.com>,
	Monam Agarwal <monamagarwal123@...il.com>,
	Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@...el.com>,
	Uma Sharma <uma.sharma523@...il.com>,
	Josh Triplett <josh@...htriplett.org>,
	Daniel Ngu <daniel.dy.ngu@...il.com>,
	Robert Nachlinger <robert.nachlinger@...il.com>,
	Ebru Akagunduz <ebru.akagunduz@...il.com>,
	Octavian Purdila <octavian.purdila@...el.com>,
	Kiran Padwal <kiran.padwal21@...il.com>,
	Alexey Khoroshilov <khoroshilov@...ras.ru>,
	Aybuke Ozdemir <aybuke.147@...il.com>,
	Cihangir Akturk <cakturk@...il.com>,
	Abel Moyo <abelmoyo.ab@...il.com>,
	Himangi Saraogi <himangi774@...il.com>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] Staging: gdm724x: code style improvements

On Fri, Feb 13, 2015 at 1:05 AM, Dan Carpenter <dan.carpenter@...cle.com> wrote:
>
> You're doing too many things at one.  This should probably be split into
> 7 patches.

I will split this up and resubmit.

>
>
>>  u16 gdm_cpu_to_dev16(struct gdm_endian *ed, u16 x)
>> @@ -39,7 +38,7 @@ u16 gdm_cpu_to_dev16(struct gdm_endian *ed, u16 x)
>>       if (ed->dev_ed == ed->host_ed)
>>               return x;
>>
>> -     return Endian16_Swap(x);
>> +     return ENDIAN16_SWAP(x);
>>  }
>
> All the changes are good except these.  We have standard macros
> cpu_to_be16()/le16() and back for these.
>
> regards,
> dan carpenter

Thanks, I'll skip this one.

Regards,
Tolga Ceylan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/