linux-kernel - Re: [PATCH v2] dgnc: Use ccflags -y instead of EXTRA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 14 Feb 2015 01:25:58 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Cass May <cass@...sm.net>
Cc:	lidza.louina@...il.com, markh@...pro.net,
	devel@...verdev.osuosl.org, driverdev-devel@...uxdriverproject.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] dgnc: Use ccflags -y instead of EXTRA_CFLAGS

On Fri, Feb 13, 2015 at 08:01:36PM +0000, Cass May wrote:
> Correction to syntax error in previous patch version. Apologies.
> 

Put that stuff under the --- cut off line and not in the permanent
kernel git log.

Changelog is missing.  checkpatch.pl by itself is not sufficient
justification.  Why did the authors of checkpatch think this way is
better?

> Signed-off-by: Cass May <cass@...sm.net>
> ---
>  drivers/staging/dgnc/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/dgnc/Makefile b/drivers/staging/dgnc/Makefile
> index b69f7b6..a278900 100644
> --- a/drivers/staging/dgnc/Makefile
> +++ b/drivers/staging/dgnc/Makefile
> @@ -1,4 +1,4 @@
> -EXTRA_CFLAGS += -DDG_NAME=\"dgnc-1.3-16\" -DDG_PART=\"40002369_F\"
> +ccflags-y := -DDG_NAME=\"dgnc-1.3-16\" -DDG_PART=\"40002369_F\"

This isn't the right fix.  Is this stuff even needed?  Hopefully, not
but please check and resend a different fix.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/