linux-kernel - Re: linux-next: Tree for Feb 13 (runtime failures and 'non-zero nr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150214103734.3052cd2f@canb.auug.org.au>
Date:	Sat, 14 Feb 2015 10:37:34 +1100
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Guenter Roeck <linux@...ck-us.net>
Cc:	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	"Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Sabrina Dubroca <sd@...asysnail.net>
Subject: Re: linux-next: Tree for Feb 13 (runtime failures and 'non-zero
 nr_pmds' messages)

Hi Guenter,

On Fri, 13 Feb 2015 10:54:28 -0800 Guenter Roeck <linux@...ck-us.net> wrote:
>
> I see a number of runtime failures with this version.
> It affects alpha, mips64, ppc64, and x86_64.
> Symptom is always the same. There are lots of
> 
> BUG: non-zero nr_pmds on freeing mm: X (where X is 1..4)
> 
> messages in the log, and the affected VMs don't reboot.
> 
> I don't see the problem in curent mainline, nor in mmotm.
> Bisect points to "Merge branch 'akpm-current/current'",
> which isn't really helpful.
> 
> Not sure if this is a bad merge resolution, so just take this
> as a heads-up for now.

Yours is the second report overnight (see attached).  Almost certainly
a bad merge resolution on my part (its a bit hard when Andrew get part
of his patch set merged by Linus :-()

I will fix up the merge on Monday (unless Andrew gets more stuff merged
or updates mmotm for me).

Sorry about that.
-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au

Return-Path: <sd@...asysnail.net>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on bilbo.ozlabs.org
X-Original-To: sfr@...b.auug.org.au
Delivered-To: sfr@...abs.org
Received: from smtp3-g21.free.fr (smtp3-g21.free.fr [212.27.42.3])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by ozlabs.org (Postfix) with ESMTPS id 5662314028E
	for <sfr@...b.auug.org.au>; Fri, 13 Feb 2015 22:03:36 +1100 (AEDT)
Received: from kria (unknown [IPv6:2a01:e35:8b11:1410:6ea0:5486:4093:b69])
	by smtp3-g21.free.fr (Postfix) with ESMTP id A70C7A6321;
	Fri, 13 Feb 2015 12:03:22 +0100 (CET)
Date: Fri, 13 Feb 2015 12:03:26 +0100
From: Sabrina Dubroca <sd@...asysnail.net>
To: Stephen Rothwell <sfr@...b.auug.org.au>
Cc: linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	"Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>
Subject: Re: linux-next: Tree for Feb 13
Message-ID: <20150213110326.GA26177@...a>
References: <20150213165615.1ad43047@...b.auug.org.au>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20150213165615.1ad43047@...b.auug.org.au>
User-Agent: Mutt/1.5.23 (2014-03-12)

2015-02-13, 16:56:15 +1100, Stephen Rothwell wrote:
> Hi all,
> 
> Please do not add any material destined for v3.21 to your linux-next
> included trees until after v3.20-rc1 has been released.
> 
> Changes since 20150212:

Hi Stephen,

Your conflict resolution in

8fe7fba50596 "Merge branch 'akpm-current/current'"

for mm/memory.c looks a bit off.  I get flooded with these messages:

  BUG: non-zero nr_pmds on freeing mm: 4

and fixed it with:


diff --git a/mm/memory.c b/mm/memory.c
index 450e4952c5ef..802adda2b0b6 100644
--- a/mm/memory.c
+++ b/mm/memory.c
@@ -3350,7 +3350,6 @@ int __pmd_alloc(struct mm_struct *mm, pud_t *pud, unsigned long address)
 	smp_wmb(); /* See comment in __pte_alloc */
 
 	spin_lock(&mm->page_table_lock);
-	mm_inc_nr_pmds(mm);
 #ifndef __ARCH_HAS_4LEVEL_HACK
 	if (!pud_present(*pud)) {
 		mm_inc_nr_pmds(mm);


references:
http://www.spinics.net/lists/linux-mm/msg84294.html
dc6c9a35b66b "mm: account pmd page tables to the process"

[CC'ed Kirill A. Shutemov]


Thanks

-- 
Sabrina


Content of type "application/pgp-signature" skipped