linux-kernel - Re: [PATCH 2/6] timekeeping: Pass readout base to update_fast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALAqxLV1fKx+8oMT__pb2sTds+cMv+DmdXHFHd-voTiiVgar4Q@mail.gmail.com>
Date:	Fri, 13 Feb 2015 08:29:13 +0800
From:	John Stultz <john.stultz@...aro.org>
To:	"Rafael J. Wysocki" <rjw@...ysocki.net>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	Peter Zijlstra <peterz@...radead.org>,
	Alan Cox <alan@...ux.intel.com>,
	"Li, Aubrey" <aubrey.li@...ux.intel.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Linux PM list <linux-pm@...r.kernel.org>,
	ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
	Kristen Carlson Accardi <kristen@...ux.intel.com>,
	Len Brown <len.brown@...el.com>
Subject: Re: [PATCH 2/6] timekeeping: Pass readout base to update_fast_timekeeper()

On Wed, Feb 11, 2015 at 12:01 PM, Rafael J. Wysocki <rjw@...ysocki.net> wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
>
> Modify update_fast_timekeeper() to take a struct tk_read_base
> pointer as its argument (instead of a struct timekeeper pointer)
> and update its kerneldoc comment to reflect that.
>
> That will allow a struct tk_read_base that is not part of a
> struct timekeeper to be passed to it in the next patch.
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>

Thomas was really behind the update_fast_timekeeper design so I'm not
sure I can critique if this fits in the larger vision here, but I
don't see anything wrong and its not breaking in any of my tests,
so...

Acked-by: John Stultz <john.stultz@...aro.org>

thanks
-john
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/