linux-kernel - Re: [PATCH 3/3] mm: slub: Add SLAB_DEBUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.11.1502131810520.14741@gentwo.org>
Date:	Fri, 13 Feb 2015 18:16:52 -0600 (CST)
From:	Christoph Lameter <cl@...ux.com>
To:	Chris J Arges <chris.j.arges@...onical.com>
cc:	David Rientjes <rientjes@...gle.com>, linux-kernel@...r.kernel.org,
	Jonathan Corbet <corbet@....net>,
	Pekka Enberg <penberg@...nel.org>,
	Joonsoo Kim <iamjoonsoo.kim@....com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-doc@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH 3/3] mm: slub: Add SLAB_DEBUG_CRASH option

On Fri, 13 Feb 2015, Chris J Arges wrote:

> The diff doesn't show this clearly, but the BUG_ON was added to both
> free_debug_processing and alloc_debug_processing.

This is not good. There should be no BUG_ON. The problem report by the
allocator already includes a backtrace. You need to abort with the crash
dump. Maybe print a message describing what is going on before.

Crash dump and abort would make most sense in slab_err() and object_err().


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/