linux-kernel - Re: [PATCH 2/3] mfd: intel_soc_pmic: Do not mangle error code from devm_gpiod_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150216114939.GC2037@x1>
Date:	Mon, 16 Feb 2015 11:49:39 +0000
From:	Lee Jones <lee.jones@...aro.org>
To:	Jarkko Nikula <jarkko.nikula@...ux.intel.com>
Cc:	linux-kernel@...r.kernel.org, Samuel Ortiz <sameo@...ux.intel.com>,
	lejun.zhu@...ux.intel.com, bin.yang@...el.com
Subject: Re: [PATCH 2/3] mfd: intel_soc_pmic: Do not mangle error code from
 devm_gpiod_get_index()

On Fri, 13 Feb 2015, Jarkko Nikula wrote:

> It is usually better to pass actual error code from a function call than
> mangling it to another.
> 
> Signed-off-by: Jarkko Nikula <jarkko.nikula@...ux.intel.com>
> ---
> I haven't seen any issue with this. Random observation by looking at the code.
> ---
>  drivers/mfd/intel_soc_pmic_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

> diff --git a/drivers/mfd/intel_soc_pmic_core.c b/drivers/mfd/intel_soc_pmic_core.c
> index 08c8e3dafaf5..40488e5b52ef 100644
> --- a/drivers/mfd/intel_soc_pmic_core.c
> +++ b/drivers/mfd/intel_soc_pmic_core.c
> @@ -33,7 +33,7 @@ static int intel_soc_pmic_find_gpio_irq(struct device *dev)
>  
>  	desc = devm_gpiod_get_index(dev, "intel_soc_pmic", 0);
>  	if (IS_ERR(desc))
> -		return -ENOENT;
> +		return PTR_ERR(desc);
>  
>  	irq = gpiod_to_irq(desc);
>  	if (irq < 0)

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/