linux-kernel - RE: [PATCH 0/6] Drivers: hv: vmbus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <F792CF86EFE20D4AB8064279AFBA51C61F34F0AD@HKNPRD3002MB017.064d.mgd.msft.net>
Date:	Mon, 16 Feb 2015 03:19:05 +0000
From:	Dexuan Cui <decui@...rosoft.com>
To:	KY Srinivasan <kys@...rosoft.com>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devel@...uxdriverproject.org" <devel@...uxdriverproject.org>,
	"olaf@...fle.de" <olaf@...fle.de>,
	"apw@...onical.com" <apw@...onical.com>,
	"vkuznets@...hat.com" <vkuznets@...hat.com>
Subject: RE: [PATCH 0/6] Drivers: hv: vmbus 

> -----Original Message-----
> From: devel [mailto:driverdev-devel-bounces@...uxdriverproject.org] On Behalf
> Of K. Y. Srinivasan
> Sent: Monday, February 16, 2015 4:11 AM
> To: gregkh@...uxfoundation.org; linux-kernel@...r.kernel.org;
> devel@...uxdriverproject.org; olaf@...fle.de; apw@...onical.com;
> vkuznets@...hat.com
> Subject: [PATCH 0/6] Drivers: hv: vmbus
> 
> The host can rescind an offer any time after the offer has been made
> to the guest. This patch-set cleans up how we handle rescind messages
> from the host.
> 
> 
> K. Y. Srinivasan (6):
>   Drivers: hv: vmbus: Properly handle child device remove
>   Drivers: hv: vmbus: Introduce a function to remove a rescinded offer
>   Drivers: hv: vmbus: Handle both rescind and offer messages in the
>     same context
>   Drivers: hv: vmbus: Remove the channel from the channel list(s) on
>     failure
>   Drivers: hv: util: On device remove, close the channel after
>     de-initializing the service
>   Drivers: hv: vmbus: Get rid of some unnecessary messages
> 
>  drivers/hv/channel.c      |    9 ++++
>  drivers/hv/channel_mgmt.c |   95 ++++++++++++++++++++------------------------
>  drivers/hv/connection.c   |    7 +---
>  drivers/hv/hv_util.c      |    2 +-
>  drivers/hv/vmbus_drv.c    |   26 +++++++++---
>  include/linux/hyperv.h    |    1 +
>  6 files changed, 74 insertions(+), 66 deletions(-)
> 
> --

The patchset seems good to me.
Reviewed-by: Dexuan Cui <decui@...rosoft.com>

BTW, IMO we need one more patch to remove the queue_work() in
free_channel() -- just make it an ordinary synchronous function call:

vmbus_process_offer() can invoke free_channel() on error path,
and vmbus_process_rescind() can invoke free_channel() too.
We should exclude the possible race.

And now the controlwq and work fields of struct vmbus_channel
are useless now.

Thanks,
-- Dexuan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/