linux-kernel - Re: [PATCH v3 1/6] mfd: max77843: Add max77843 MFD driver core driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150216134206.GH14545@x1>
Date:	Mon, 16 Feb 2015 13:42:06 +0000
From:	Lee Jones <lee.jones@...aro.org>
To:	Chanwoo Choi <cw00.choi@...sung.com>
Cc:	Jaewon Kim <jaewon02.kim@...sung.com>,
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
	linux-pm@...r.kernel.org, Inki Dae <inki.dae@...sung.com>,
	SangBae Lee <sangbae90.lee@...sung.com>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Sebastian Reichel <sre@...nel.org>,
	Mark Brown <broonie@...nel.org>,
	Beomho Seo <beomho.seo@...sung.com>
Subject: Re: [PATCH v3 1/6] mfd: max77843: Add max77843 MFD driver core driver

On Wed, 04 Feb 2015, Chanwoo Choi wrote:
> On 02/04/2015 01:56 PM, Jaewon Kim wrote:
> > This patch adds MAX77843 core/irq driver to support PMIC,
> > MUIC(Micro USB Interface Controller), Charger, Fuel Gauge,
> > LED and Haptic device.
> > 
> > Cc: Lee Jones <lee.jones@...aro.org>
> > Signed-off-by: Jaewon Kim <jaewon02.kim@...sung.com>
> > Signed-off-by: Beomho Seo <beomho.seo@...sung.com>
> > ---
> >  drivers/mfd/Kconfig                  |   14 ++
> >  drivers/mfd/Makefile                 |    1 +
> >  drivers/mfd/max77843.c               |  245 +++++++++++++++++++
> >  include/linux/mfd/max77843-private.h |  441 ++++++++++++++++++++++++++++++++++
> >  4 files changed, 701 insertions(+)
> >  create mode 100644 drivers/mfd/max77843.c
> >  create mode 100644 include/linux/mfd/max77843-private.h

<LOTS OF POINTLESS LINES OF UNCHANGED/UNREVIEWED CODE>

> Looks good to me.
> 
> Reviewed-by: Chanwoo Choi <cw00.choi@...sung.com>

Chanwoo,

If you're not going to make any comments, either put the Reviewed-by
at the top, or better still, snip out all of the bumph in the middle.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/